Attention is currently required from: pespin. daniel has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39224?usp=email ) Change subject: mgw: CRCX: Split mgcp header pars parsing into a previous step ...................................................................... Patch Set 1: (3 comments) File include/osmocom/mgcp/mgcp_msg.h: https://gerrit.osmocom.org/c/osmo-mgw/+/39224/comment/fb710223_63ae146a?usp… : PS1, Line 29: #include <ctype.h> Seems unnecessary here File include/osmocom/mgcp/mgcp_protocol.h: https://gerrit.osmocom.org/c/osmo-mgw/+/39224/comment/3491d1ca_95d5be6f?usp… : PS1, Line 31: //struct mgcp_parsed_body { : //}; Remove File src/libosmo-mgcp/mgcp_msg.c: https://gerrit.osmocom.org/c/osmo-mgw/+/39224/comment/9c273cb9_d00ac27f?usp… : PS1, Line 176: * \param[in] endp pointer to endpoint (only used for log output, may be NULL) I don't know if these helped debug issues in the past, but this change also makes the log messages a little less informative -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/39224?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I3ee5158c254213203830fe9c38de11c15b4b19c1 Gerrit-Change-Number: 39224 Gerrit-PatchSet: 1 Gerrit-Owner: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-CC: daniel &lt;dwillmann(a)sysmocom.de&gt; Gerrit-Attention: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Comment-Date: Fri, 03 Jan 2025 15:05:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No