Attention is currently required from: dexter.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32153 )
Change subject: MGCP_Test: support multiple codecs ......................................................................
Patch Set 5:
(6 comments)
File library/RTP_Emulation.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32153/comment/ec2f6749_8e684... PS5, Line 393: if (ispresent(g_cfg.rx_payloads[i].fixed_payload)) { if (not ispresent(g_cfg.rx_payloads[i].fixed_payload)) return;
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32153/comment/d57359db_3da54... PS5, Line 395: full_match := full_match + 1; return;
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32153/comment/45f7deb0_9394b... PS5, Line 396: } else { "else" can be dropped after return;
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32153/comment/1ff8adb2_1871d... PS5, Line 397: payload_type_match := payload_type_match + 1; g_stats_rtp.num_pkts_rx_err_payload := g_stats_rtp.num_pkts_rx_err_payload + 1; return;
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32153/comment/169cca6c_c4f3e... PS5, Line 406: if (full_match > 0) { This can now be dropped.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32153/comment/ea9e9a94_61dcd... PS5, Line 411: if (payload_type_match > 0) { This can be dropped.