Attention is currently required from: laforge, pespin, dexter. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32970 ) Change subject: all models, HR1 codec: select RTP output format via vty option ...................................................................... Patch Set 1: (1 comment) File src/common/bts.c: https://gerrit.osmocom.org/c/osmo-bts/+/32970/comment/99b9cf1d_525c3628 PS1, Line 333: bts->emit_hr_rfc5993 = true; I am not sure if it is wise to have a static default. I am a bit worried about existing deployments. A user of a DSP based BTS might rely on it using TS 101318 format. So after an update the deployment may cease to work. This is something to keep in mind. I would use the BTS feature flags, like in this change: I9419b40c1171876879d41aba4f51c93e8ef5673c -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32970 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I168191874a062429a57904511a1e89e3f588732e Gerrit-Change-Number: 32970 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: dexter <pmaier(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 24 May 2023 17:50:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment