Attention is currently required from: laforge, pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmocom-bb/+/35507?usp=email )
Change subject: mobile: fix segfault on empty TRAFFIC.ind
......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS2:
wouldn't we have to inject a silence frame, or a
duplicate of the previous, or something? Otherweis […]
Ideally, yes. I think
there's even ECU for FR in the playback chain. The problem is that there's
currently no _proper_ way to signal to the ECU block that it's a bad frame and that it
needs to be engaged. Another problem is that there's a format converter block between
the fb and the ECU, which does expect a fixed number of bytes at the input. So this is
quite a lot of work and TODO...
PS2:
Maybe it would be better to avoid enqueuing an empty
frame in first place, to avoid allocating and f […]
See Harald's comment about
injecting silence frames. We may want to implement this at some point in the future. But
for now let's make sure that at least the whole process does not crash.
--
To view, visit
https://gerrit.osmocom.org/c/osmocom-bb/+/35507?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Ice11b72ddfd51fbfb17a4c609c664b86a8f69591
Gerrit-Change-Number: 35507
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 09 Jan 2024 13:20:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment