Attention is currently required from: pespin, fixeria.
dexter has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/32733
)
Change subject: paging: parse PCUIF data indication outside of paging.c
......................................................................
Patch Set 1:
(2 comments)
File include/osmo-bts/paging.h:
https://gerrit.osmocom.org/c/osmo-bts/+/32733/comment/9a25e75c_2c83e838
PS1, Line 40: int paging_add_macblock(struct paging_state *ps, const char *imsi,
this is not really an imsi, but an imsi_suffix right?
3 chars. […]
At the moment we indeed pass the suffix, but in PCUIF v.11 we will pass
the full IMSI, so I made it compatible.
File src/common/paging.c:
https://gerrit.osmocom.org/c/osmo-bts/+/32733/comment/19bab532_529680ea
PS1, Line 272: int paging_add_macblock(struct paging_state *ps, const char *imsi,
imsi_suffix
(see first comment)
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bts/+/32733
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I9f3799916e8102bf1ce0f21891f2d24f43091f01
Gerrit-Change-Number: 32733
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 16 May 2023 14:59:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment