pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31241 ) Change subject: library/GSM_Types: fix encoding of BcdMccMnc (3 octets) ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: This commit is causing regressions in lots of nacc related tests in ttcn3-pcu-test. as_outbound_nacc_rim_resolve() no longer matches the received "Source Cell Identifier" in RAN-INFORMATION-REQUEST: var BssgpCellId src := valueof(ts_BssgpCellId(ts_RAI(ts_LAI(f_enc_BcdMccMnc_int(info_ind.mcc, info_ind.mnc, info_ind.mnc_3_digits == 1), info_ind.lac), info_ind.rac), info_ind.cell_id)); where info_ind is: friend template (value) PCUIF_info_ind ts_PCUIF_INFO_default(template (value) PCUIF_Flags flags := c_PCUIF_Flags_default) := { version := PCUIF_Types.mp_pcuif_version, flags := flags, trx := ts_PCUIF_InfoTrxs_def(GPRS_Components.mp_base_arfcn), bsic := 7, mcc := 262, mnc := 42, mnc_3_digits := 0, lac := 13135, rac := 0, nsei := mp_nsconfig.nsei, nse_timer := { 3, 3, 3, 3, 30, 3, 10 }, cell_timer := { 3, 3, 3, 3, 3, 10, 3, 10, 3, 10, 3 }, cell_id := 20960, Wireshark seems to be saying it's correct to: RIM Routing Information - Source Cell Identifier - RAI: 262-42-13135-0, CI 20960 12:03:53.206131 mtc PCU_Tests.ttcn:5172 Matching on port RIM .pDU_BSSGP_RAN_INFORMATION_REQUEST.source_Cell_Identifier.rIM_Routing_Address.cell_Identifier.mccDigit1 := '2'H with '6'H unmatched.pDU_BSSGP_RAN_INFORMATION_REQUEST.source_Cell_Identifier.rIM_Routing_Address.cell_Identifier.mccDigit2 := '6'H with '2'H unmatched.pDU_BSSGP_RAN_INFORMATION_REQUEST.source_Cell_Identifier.rIM_Routing_Address.cell_Identifier.mccDigit3 := '2'H with 'F'H unmatched.pDU_BSSGP_RAN_INFORMATION_REQUEST.source_Cell_Identifier.rIM_Routing_Address.cell_Identifier.mncDigit3 := 'F'H with '2'H unmatched.pDU_BSSGP_RAN_INFORMATION_REQUEST.source_Cell_Identifier.rIM_Routing_Address.cell_Identifier.mncDigit1 := '4'H with '2'H unmatched.pDU_BSSGP_RAN_INFORMATION_REQUEST.source_Cell_Identifier.rIM_Routing_Address.cell_Identifier.mncDigit2 := '2'H with '4'H unmatched: First message in the queue does not match the template: -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31241 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ifa3083fdd6307b56baa1ef3ac85a3e7a2efab728 Gerrit-Change-Number: 31241 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 09 Feb 2023 13:49:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment