Attention is currently required from: pespin, fixeria. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/31741 ) Change subject: build: fix linking gen__pfcp_ies_auto to use build-tree libosmo-gtlv ...................................................................... Patch Set 1: (1 comment) File src/libosmo-pfcp/Makefile.am: https://gerrit.osmocom.org/c/libosmo-pfcp/+/31741/comment/7f30d7fa_0347fc4c PS1, Line 68: gen__pfcp_ies_auto_LDFLAGS erm ok, of course there is some linking phase for the library and it has LDFLAGS. What i meant is the library linking doesn't need to link the actual objects it depends on -- so the LDFLAGS for libosmo-pfcp doesn't need to link libosmocore.so or libosmogsm.so. And what i meant is the library has its own LDFLAGS directive, so it doesn't use the global AM_LDFLAGS directive. building the library still needs the CFLAGS for the #includes from the .c/.h files. only the gen__pfcp_... tool needs to add the actual FOO_LIBS to LDFLAGS to build the executable. so it will have its own LDFLAGS now. -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/31741 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I2e92238b214d8e79bab1095d6093139bad05bc66 Gerrit-Change-Number: 31741 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 09 Mar 2023 00:12:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment