Attention is currently required from: jolly, fixeria, pespin.
dexter has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-pcu/+/32694
)
Change subject: gprs_rlcmac: also use PCU_IF_SAPI_PCH_DT for paging MAC blocks
......................................................................
Patch Set 3:
(3 comments)
Commit Message:
https://gerrit.osmocom.org/c/osmo-pcu/+/32694/comment/359d118e_10c4dc22
PS1, Line 7: gprs_rlcmac: also use direct TLLI PCUIF for paging macblocks
I just mean a MAC block with a paging message inside.
[…]
Done
Commit Message:
https://gerrit.osmocom.org/c/osmo-pcu/+/32694/comment/f4c21dd9_78d8a4ff
PS2, Line 15: It was not clear that PAGING
: COMMAND and IMMEDIATE ASSIGNMENT (via PCH) require a confirmation by the
: receiving end
Reading this patch again I am not sure if I understand
the goal you're aiming to achieve. […]
I noticed that as well. It was the fact
that osmo-bts would confirm IMMEDIATE ASSIGNMENT and PAGING commands equally that lead me
on the wrong path.
Patchset:
PS3:
This is now updated and should be correct now.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-pcu/+/32694
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I99cfe373fa157cfb32b74c113ad9935347653a71
Gerrit-Change-Number: 32694
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 16 May 2023 14:51:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: comment