Attention is currently required from: laforge, msuraev.
osmith has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-e1d/+/30024
)
Change subject: jenkins.sh: Support for building + publishing the manual
......................................................................
Patch Set 7: Code-Review+1
(2 comments)
Patchset:
PS4:
I spent a lot of time investing it as well. osmoe1d-usermanual.pdf does not get built in
"make distcheck", leading to the error later where "make install"
can't install it. With debug flags for make:
No need to remake target
'osmoe1d-usermanual.pdf'; using VPATH name
'../../../../doc/manuals/osmoe1d-usermanual.pdf'.
So because the pdf is already built in the source directory before we run "make
distcheck", make figures it exists already and doesn't try to rebuild it. I
wonder why this works in osmo-hlr and other projects... but since I spent a lot of time
also at this point and I don't think it matters if we build the manuals in "make
distcheck" or not (we build them twice in CI already, in the regular build and in the
deb package!), I decided to do "make distcheck" with --disable-manuals.
Interestingly there's a similar problem with doxygen, so I've done
--disable-doxygen in the next patch too.
File Makefile.am:
https://gerrit.osmocom.org/c/osmo-e1d/+/30024/comment/f092a1b4_e5880423
PS4, Line 5: doc \
Is the order of subdirs matter?
probably done by
accident, changed it back - the result of the build is the same
--
To view, visit
https://gerrit.osmocom.org/c/osmo-e1d/+/30024
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-e1d
Gerrit-Branch: master
Gerrit-Change-Id: Ic399662e6ac5e5e7f999e6e7127df9a9580a0627
Gerrit-Change-Number: 30024
Gerrit-PatchSet: 7
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 07 Nov 2022 13:55:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de>
Gerrit-MessageType: comment