Attention is currently required from: Hoernchen.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-trx/+/32762
)
Change subject: transceiver: pass cfg struct instead of args
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
I find it difficult to review this patch because afaict there's several steps merged
int one:
- replacement of constructor params at different levels (could already be more than one
patch)
- replacement of open() method params
- some sort of change with dev_args which I fail to easily understand with all the code
changing around, and which looks at first glance unrelated to this patch.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-trx/+/32762
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I48386900d15ff4d770c70a4efc246d32f921904b
Gerrit-Change-Number: 32762
Gerrit-PatchSet: 3
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 17 May 2023 16:58:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment