Attention is currently required from: jolly, fixeria, dexter.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-pcu/+/32694
)
Change subject: gprs_rlcmac: also use direct TLLI PCUIF for paging macblocks
......................................................................
Patch Set 1:
(4 comments)
Commit Message:
https://gerrit.osmocom.org/c/osmo-pcu/+/32694/comment/8a3160af_5e2066d9
PS1, Line 7: gprs_rlcmac: also use direct TLLI PCUIF for paging macblocks
not sure what "paging backblocks" means here.
https://gerrit.osmocom.org/c/osmo-pcu/+/32694/comment/363d7246_6fcaa9e7
PS1, Line 28: OS##5927
only one `#` please
Ack
File src/gprs_rlcmac.c:
https://gerrit.osmocom.org/c/osmo-pcu/+/32694/comment/23c22d69_b53fcdb5
PS1, Line 20: #include <osmocom/core/bitvec.h>
why adding this header?
It is clear this file
uses bitved, but maybe it should be added as a separate patch.
https://gerrit.osmocom.org/c/osmo-pcu/+/32694/comment/cf69da90_6e7eb922
PS1, Line 49: mi->tmsi
You're saying TLLI, but actually passing a TMSI --
this is not always the same thing. […]
Ack
--
To view, visit
https://gerrit.osmocom.org/c/osmo-pcu/+/32694
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I99cfe373fa157cfb32b74c113ad9935347653a71
Gerrit-Change-Number: 32694
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 15 May 2023 12:10:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment