neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/32716 ) Change subject: fix missing write-back of rnc-id ...................................................................... fix missing write-back of rnc-id Change-Id: Ide006379b26949e34371bd316a22c130ea09da82 --- M src/osmo-hnbgw/hnbgw_vty.c M tests/osmo-hnbgw.vty 2 files changed, 21 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve neels: Looks good to me, approved diff --git a/src/osmo-hnbgw/hnbgw_vty.c b/src/osmo-hnbgw/hnbgw_vty.c index 93eca41..2952913 100644 --- a/src/osmo-hnbgw/hnbgw_vty.c +++ b/src/osmo-hnbgw/hnbgw_vty.c @@ -416,9 +416,13 @@ static int config_write_hnbgw(struct vty *vty) { vty_out(vty, "hnbgw%s", VTY_NEWLINE); + + vty_out(vty, " rnc-id %u%s", g_hnbgw->config.rnc_id, VTY_NEWLINE); + vty_out(vty, " log-prefix %s%s", g_hnbgw->config.log_prefix_hnb_id ? "hnb-id" : "umts-cell-id", VTY_NEWLINE); osmo_tdef_vty_groups_write(vty, " "); + return CMD_SUCCESS; } diff --git a/tests/osmo-hnbgw.vty b/tests/osmo-hnbgw.vty index b2bf305..72916fb 100644 --- a/tests/osmo-hnbgw.vty +++ b/tests/osmo-hnbgw.vty @@ -25,11 +25,16 @@ <0-65535> RNC Id value OsmoHNBGW(config-hnbgw)# show running-config -... !rnc-id +... +hnbgw +... + rnc-id 23 +... OsmoHNBGW(config-hnbgw)# rnc-id 42 -OsmoHNBGW(config-hnbgw)# ### ERROR! We don't write back the rnc-id OsmoHNBGW(config-hnbgw)# show running-config ... hnbgw -... !rnc-id +... + rnc-id 42 +... -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/32716 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ide006379b26949e34371bd316a22c130ea09da82 Gerrit-Change-Number: 32716 Gerrit-PatchSet: 5 Gerrit-Owner: neels &lt;nhofmeyr(a)sysmocom.de&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-Reviewer: neels &lt;nhofmeyr(a)sysmocom.de&gt; Gerrit-Reviewer: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-MessageType: merged