Attention is currently required from: pespin, fixeria, dexter.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31417 )
Change subject: l1sap: Accept RFC5993 and TS 101.318 HR GSM payload ......................................................................
Patch Set 5:
(1 comment)
File src/common/l1sap.c:
https://gerrit.osmocom.org/c/osmo-bts/+/31417/comment/89786253_25e66897 PS5, Line 1267: && bts_internal_flag_get(lchan->ts->trx->bts, BTS_INTERNAL_FLAG_SPEECH_H_V1_RTP_TS101318))) {
same
agreeing with pespin. The fact that the constant BTS_INTERNAL_FLAG_SPEECH_H_V1_RTP_TS101318 is ridiculously long makes it virtually impossible to write code that fits into a line. One could pooissibly use a local 'bts' variable to avoid the lchan->ts->trx->bts chain. Or one could have boolean variables for the results of bts_internal_flag_get and just use those boolean variables here, fitting in the same line as the OSMO_UNLIKELY().
-
laforge