Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/30121 ) Change subject: [codecs filter] MT call: apply remote call leg codecs ...................................................................... Patch Set 1: (1 comment) File src/libmsc/gsm_04_08_cc.c: https://gerrit.osmocom.org/c/osmo-msc/+/30121/comment/206b6f18_32b24930 PS1, Line 723: trans->bearer_cap = bearer_cap; The main aim in this function is to send a Bearer Cap to the MS in a CC Setup message, that is what the local variable bearer_cap is about. Previous code also placed this info in trans->bearer_cap, which I believe is no longer necessary once the codecs filter is fully in place -- it is likely to be dropped, so trans->bearer_cap is just a legacy leftover. Keeping it for now. BTW, my intention was to separate the patches that store info in the codecs filter from patches that actually use the filter result -- this patch did both, as i noticed now, so i separated this patch further; see I9586221ef56352b7ce4b2604ae0dc04554145a78 (to be submitted soon) for the part that i removed here. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/30121 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I84d9bbca3e4061da622b1b2fc0bde8868e7e3521 Gerrit-Change-Number: 30121 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 17 Nov 2022 00:15:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment