Attention is currently required from: fixeria, dexter. falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32740 ) Change subject: gsm630: make osmo_hr_check_sid compatible with RFC 5993 ...................................................................... Patch Set 1: (2 comments) Commit Message: https://gerrit.osmocom.org/c/libosmocore/+/32740/comment/4718014e_019ba0b1 PS1, Line 7: gsm630: make osmo_hr_check_sid compatible with RFC 5993 I assume you meant gsm620 here. Patchset: PS1: I am not certain at all that the right solution to OS#5688 is to propagate the knowledge of two different RTP formats deep into the innards of our code. Wouldn't it be much cleaner to check the RTP encoding format at the very beginning of RTP input processing in OsmoBTS (or in OsmoMGW feeding E1 Abis), in the same place where calls to osmo_{fr,efr}_sid_preen() have been inserted recently, strip the extraneous RFC 5993 ToC octet if one is present, and then work only with the TS 101 318 format internally throughout our code base? And in the other direction, if the desire is to emit RFC 5993 format to the outside world (configurable per vty, ideally), likewise work in TS 101 318 format internally, but prepend the extra ToC octet just before RTP output. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32740 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I25728299b757fbc87dd1b3f5adaec9b8b240c5d1 Gerrit-Change-Number: 32740 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 17 May 2023 14:19:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment