Attention is currently required from: neels, pespin.
dexter has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/31618
)
Change subject: pcu_sock: handle multiple BTSs with multiple BSC co-located PCUs
......................................................................
Patch Set 8:
(1 comment)
File include/osmocom/bsc/pcu_if.h:
https://gerrit.osmocom.org/c/osmo-bsc/+/31618/comment/f373d53c_6b827be6
PS7, Line 11: struct gsm_bts *bts; /* BTS that is associated with this PCU */
I am really not following here. […]
(we
discussed this also in IRC)
We assign a single BTS to one PCU socket, but we also have one PCU socket per BTS. So its
a 1:1 relationship.
It is true that this is not how the PCUIF protocol was envisioned. I first followed the
idea of the PCU protocol but then I noticed that the VTY assigns one PCU socket per BTS.
Since this was already there I decided to follow the one PCU per BTS model.
I also think that the one PCU per BTS approach is better since it would not concentrate
the processing load in one process when multiple BTSs are used. It is also more likely to
work since we didn't test OsmoPCU with multiple BTSs yet. Also a PCU crash will not
affect all BTSs at once.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/31618
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I0b42c2c130106f6ffca2dd08d079e1a7bda41f0b
Gerrit-Change-Number: 31618
Gerrit-PatchSet: 8
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 07 Mar 2023 13:53:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment