Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30821 ) Change subject: bsc: Fix crash if PagingResponse with invalid MobileIdentity is received ...................................................................... Patch Set 1: Code-Review+2 (1 comment) File src/osmo-bsc/gsm_08_08.c: https://gerrit.osmocom.org/c/osmo-bsc/+/30821/comment/81daa178_b1c7f49d PS1, Line 443: if (conn->bsub) We definetly need to find the subscriber since the paging requests are now stored in a list per subscriber (eg if a subscriber is paged for the entire BSS and you have 200 BTS, then you have 200 paging requests per subscriber). Having them reachable per subscriber is hence really saving lots of CPU time. Hence it really makes no sense to call paging_request_stop() if bsub is NULL now, since anyway nothing would be done in that case. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30821 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If8b439ff74c5dd690d637d3e3278c75d6cd6b928 Gerrit-Change-Number: 30821 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 02 Jan 2023 16:45:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment