Attention is currently required from: Hoernchen. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30416 ) Change subject: ms-trx support ...................................................................... Patch Set 2: (408 comments) File Transceiver52M/ms/bladerf_specific.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ac398c1c_b77b843a PS2, Line 42: template <typename Arg, typename... Args> void expand_args(std::ostream &out, Arg &&arg, Args &&...args) spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d8f013f6_0d2bcf94 PS2, Line 42: template <typename Arg, typename... Args> void expand_args(std::ostream &out, Arg &&arg, Args &&...args) spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/facaacf3_64db5128 PS2, Line 42: template <typename Arg, typename... Args> void expand_args(std::ostream &out, Arg &&arg, Args &&...args) need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3b6c019d_aa7a430c PS2, Line 42: template <typename Arg, typename... Args> void expand_args(std::ostream &out, Arg &&arg, Args &&...args) spaces required around that '&&' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3493d252_16566615 PS2, Line 42: template <typename Arg, typename... Args> void expand_args(std::ostream &out, Arg &&arg, Args &&...args) spaces required around that '&&' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4e76c7ce_defeab86 PS2, Line 44: out << '(' << std::forward<Arg>(arg); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d8ad9870_e64ae3b1 PS2, Line 44: out << '(' << std::forward<Arg>(arg); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2bb31d7a_b2b3951d PS2, Line 45: (void)(int[]){ 0, (void((out << "," << std::forward<Args>(args))), 0)... }; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2583187b_d4262b90 PS2, Line 45: (void)(int[]){ 0, (void((out << "," << std::forward<Args>(args))), 0)... }; spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/10ee9772_e31f5161 PS2, Line 49: template <class R, class... Args> using RvalFunc = R (*)(Args...); space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/17d4672d_93ea4552 PS2, Line 49: template <class R, class... Args> using RvalFunc = R (*)(Args...); spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2284c66c_7c219fa3 PS2, Line 49: template <class R, class... Args> using RvalFunc = R (*)(Args...); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6c10657a_438c9110 PS2, Line 52: template <class R, class... Args> spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/03f16073_facafa2d PS2, Line 52: template <class R, class... Args> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/dcda8fd6_5a1aeed8 PS2, Line 53: R exec_and_check(RvalFunc<R, Args...> func, const char *fname, const char *finame, const char *funcname, int line, spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e996809d_a4100ad3 PS2, Line 53: R exec_and_check(RvalFunc<R, Args...> func, const char *fname, const char *finame, const char *funcname, int line, spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d6004ca7_23b0e7a1 PS2, Line 56: R rval = func(std::forward<Args>(args)...); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8faa3170_f373e9bb PS2, Line 56: R rval = func(std::forward<Args>(args)...); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/06074678_b51e6280 PS2, Line 57: if (rval != 0) { suspect code indent for conditional statements (8, 26) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/914c1e8a_8b96bf13 PS2, Line 58: std::cerr << ((rval >= 0) ? "OK:" : bladerf_strerror(rval)) << ':' << finame << ':' << line << ':' labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8129465b_7158fe99 PS2, Line 66: #define blade_check(func, ...) exec_and_check(func, #func, __FILE__, __FUNCTION__, __LINE__, __VA_ARGS__) __func__ should be used instead of gcc specific __FUNCTION__ Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9c3f00b5_659efa9f PS2, Line 69: using blade_sample_type = std::complex<int16_t>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/79cfc92f_171096ea PS2, Line 69: using blade_sample_type = std::complex<int16_t>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d57c7c48_7f9a0b66 PS2, Line 71: template <blade_speed_buffer_type T> struct blade_usb_message { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c205ac73_4a8da9ff PS2, Line 71: template <blade_speed_buffer_type T> struct blade_usb_message { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/79d50ad1_07733d5f PS2, Line 78: static_assert(sizeof(blade_usb_message<blade_speed_buffer_type::SS>) == 2048, "blade buffer mismatch!"); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7b7aed85_d8facfa1 PS2, Line 78: static_assert(sizeof(blade_usb_message<blade_speed_buffer_type::SS>) == 2048, "blade buffer mismatch!"); spaces required around that '>' (ctx:VxB) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/58ba745a_6a570676 PS2, Line 79: static_assert(sizeof(blade_usb_message<blade_speed_buffer_type::HS>) == 1024, "blade buffer mismatch!"); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1ea732ac_903b1da2 PS2, Line 79: static_assert(sizeof(blade_usb_message<blade_speed_buffer_type::HS>) == 1024, "blade buffer mismatch!"); spaces required around that '>' (ctx:VxB) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/24164b66_780879ce PS2, Line 80: template <unsigned int SZ, blade_speed_buffer_type T> struct blade_otw_buffer { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5c762f18_b873fae3 PS2, Line 80: template <unsigned int SZ, blade_speed_buffer_type T> struct blade_otw_buffer { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0a3f696b_8c2c509e PS2, Line 82: blade_usb_message<T> m[SZ]; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1a1ff4cf_7179fe65 PS2, Line 82: blade_usb_message<T> m[SZ]; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c7aea4f2_014b0c98 PS2, Line 83: int actual_samples_per_msg() Bad function definition - int actual_samples_per_msg() should probably be int actual_samples_per_msg(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/eb633110_130cc80d PS2, Line 83: int actual_samples_per_msg() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3ffe4c6f_65caf1c2 PS2, Line 85: return sizeof(blade_usb_message<T>::d) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f5d7d863_e448474e PS2, Line 85: return sizeof(blade_usb_message<T>::d) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6a01f779_6dc0735c PS2, Line 85: return sizeof(blade_usb_message<T>::d) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d503743f_d6db6b0f PS2, Line 85: return sizeof(blade_usb_message<T>::d) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/51c994f6_0fa8ffb7 PS2, Line 87: int actual_samples_per_buffer() Bad function definition - int actual_samples_per_buffer() should probably be int actual_samples_per_buffer(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e0cc504d_9a977458 PS2, Line 87: int actual_samples_per_buffer() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8f0c1c62_63da7844 PS2, Line 91: int samples_per_buffer() Bad function definition - int samples_per_buffer() should probably be int samples_per_buffer(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5f544051_c43a6cfb PS2, Line 91: int samples_per_buffer() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4aafc47f_1a7f12d9 PS2, Line 93: return SZ * sizeof(blade_usb_message<T>) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7076fa87_1c492939 PS2, Line 93: return SZ * sizeof(blade_usb_message<T>) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '>' (ctx:VxB) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8008f6e8_4595dfa4 PS2, Line 93: return SZ * sizeof(blade_usb_message<T>) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4095380e_9b57b4ac PS2, Line 93: return SZ * sizeof(blade_usb_message<T>) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8cf93ca0_174ce3e3 PS2, Line 95: int num_msgs_per_buffer() Bad function definition - int num_msgs_per_buffer() should probably be int num_msgs_per_buffer(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7ca2752e_b93cea8a PS2, Line 95: int num_msgs_per_buffer() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6766c182_ed789b10 PS2, Line 99: auto get_first_ts() Bad function definition - auto get_first_ts() should probably be auto get_first_ts(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/db9d4c23_3912098f PS2, Line 99: auto get_first_ts() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1c293f74_39d667ae PS2, Line 103: constexpr auto *getsampleoffset(int ofs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9cc89856_2850c22d PS2, Line 109: int readall(blade_sample_type *outaddr) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/caa19eec_f21a1e03 PS2, Line 118: int read_n(blade_sample_type *outaddr, int start, int num) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c25896e6_57b28703 PS2, Line 156: int write_n_burst(blade_sample_type *in, int num, uint64_t first_ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/08736312_ce6546c7 PS2, Line 176: template <unsigned int SZ, blade_speed_buffer_type T> struct blade_otw_buffer_helper { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9731e6da_32b8fbb7 PS2, Line 176: template <unsigned int SZ, blade_speed_buffer_type T> struct blade_otw_buffer_helper { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5f83a2b9_e76b3158 PS2, Line 178: static blade_otw_buffer<SZ / 512, T> x; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/947270ed_88040ea2 PS2, Line 178: static blade_otw_buffer<SZ / 512, T> x; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ef7f2b7c_0a39d7b4 PS2, Line 181: using dev_buf_t = typeof(blade_otw_buffer_helper<BLADE_BUFFER_SIZE, blade_speed_buffer_type::SS>::x); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/348dda37_3f786b1b PS2, Line 181: using dev_buf_t = typeof(blade_otw_buffer_helper<BLADE_BUFFER_SIZE, blade_speed_buffer_type::SS>::x); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d89625fe_3cdf625f PS2, Line 183: using bh_fn_t = std::function<int(dev_buf_t *)>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f9d04593_bd5b1804 PS2, Line 183: using bh_fn_t = std::function<int(dev_buf_t *)>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7e632f69_c83126d2 PS2, Line 185: template <typename T> struct blade_hw { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/19646b00_85d1edc9 PS2, Line 185: template <typename T> struct blade_hw { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4d8d6e43_d97c363d PS2, Line 190: using tx_buf_q_type = spsc_cond<BLADE_NUM_BUFFERS, dev_buf_t *, true, false>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/51ce4983_99dc6d01 PS2, Line 190: using tx_buf_q_type = spsc_cond<BLADE_NUM_BUFFERS, dev_buf_t *, true, false>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/63d10d14_6ebfcff3 PS2, Line 202: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e5840b3c_d9146e46 PS2, Line 223: void close_device() Bad function definition - void close_device() should probably be void close_device(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/11e6e464_df921290 PS2, Line 223: void close_device() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/23fadae6_6c2158a8 PS2, Line 242: int init_device(bh_fn_t rxh, bh_fn_t txh) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fde03432_a765a96d PS2, Line 244: struct bladerf_rational_rate rate = { 0, static_cast<uint64_t>((1625e3 * 4)) * 64, 6 * 64 }, actual; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/02cf2806_d4dba24d PS2, Line 244: struct bladerf_rational_rate rate = { 0, static_cast<uint64_t>((1625e3 * 4)) * 64, 6 * 64 }, actual; spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/008dfa47_46b90165 PS2, Line 250: std::cerr << "open failed, device missing?" << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9c3a3a61_2f54bc23 PS2, Line 254: std::cerr << "open failed, only superspeed (usb3) supported!" << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8d6a57cc_aba30eb7 PS2, Line 271: std::cerr << "unable to lock refclk!" << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ae83c964_4fae6268 PS2, Line 301: auto cur_buffer = reinterpret_cast<tx_buf_q_type::elem_t *>(buf_mgmt.tx_samples); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f0c5bf5b_f111079f PS2, Line 301: auto cur_buffer = reinterpret_cast<tx_buf_q_type::elem_t *>(buf_mgmt.tx_samples); need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5ca2d6bc_46ed1b54 PS2, Line 301: auto cur_buffer = reinterpret_cast<tx_buf_q_type::elem_t *>(buf_mgmt.tx_samples); spaces required around that '>' (ctx:OxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/43a2fbb5_0ca9562b PS2, Line 316: bool tuneTx(double freq, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/61ee3a27_1a9d1604 PS2, Line 318: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a673fde2_939e168a PS2, Line 320: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9553a025_ddc5d119 PS2, Line 323: bool tuneRx(double freq, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/52d928b4_e9b7bd86 PS2, Line 325: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d50a8e44_1ab699f7 PS2, Line 327: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1ea57201_2a323fd5 PS2, Line 330: bool tuneRxOffset(double offset, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1535610d_426589ed PS2, Line 335: double setRxGain(double dB, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2a512f88_a81132d8 PS2, Line 338: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/49ac56d0_9e63cb91 PS2, Line 340: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ee369840_08598996 PS2, Line 343: double setTxGain(double dB, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/eba2ad04_b1417ceb PS2, Line 346: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/10882bc5_f3b13cd3 PS2, Line 348: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/29940493_d0247f97 PS2, Line 351: int setPowerAttenuation(int atten, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e46d7c81_67a44129 PS2, Line 356: static void check_timestamp(dev_buf_t *rcd) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fa7a3811_9b620740 PS2, Line 363: } else if (last_ts + rcd->actual_samples_per_buffer() != rcd->m[0].ts) { suspect code indent for conditional statements (16, 34) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3c666a4b_b5b421da PS2, Line 364: std::cerr << "RX Overrun!" << last_ts << " " << rcd->actual_samples_per_buffer() << " " labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/13da38ed_ed31fb12 PS2, Line 372: bladerf_stream_cb getrxcb(bh_fn_t rxbh) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3b49d024_65ac478f PS2, Line 376: return [](struct bladerf *dev, struct bladerf_stream *stream, struct bladerf_metadata *meta, space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/11a22ff2_a4c76281 PS2, Line 377: void *samples, size_t num_samples, void *user_data) -> void * { spaces prohibited around that '->' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4633e101_e7263baa PS2, Line 392: bladerf_stream_cb gettxcb(bh_fn_t txbh) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/02faffd6_25752bfd PS2, Line 396: return [](struct bladerf *dev, struct bladerf_stream *stream, struct bladerf_metadata *meta, space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c5df2a03_a8813ccf PS2, Line 397: void *samples, size_t num_samples, void *user_data) -> void * { spaces prohibited around that '->' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f26512e9_1b44bf0d PS2, Line 399: auto ptr = reinterpret_cast<tx_buf_q_type::elem_t>(samples); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2b15ad8d_979a8eb0 PS2, Line 399: auto ptr = reinterpret_cast<tx_buf_q_type::elem_t>(samples); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d1a950ac_03be3621 PS2, Line 408: auto get_rx_burst_handler_fn(bh_fn_t burst_handler) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/92fee962_138c157a PS2, Line 410: auto fn = [this] { space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/732d6e9f_1fec785e PS2, Line 414: std::cerr << "rx stream error! " << bladerf_strerror(status) << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6411ccdd_28ef651c PS2, Line 420: auto get_tx_burst_handler_fn(bh_fn_t burst_handler) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d8ed04a3_92e518b9 PS2, Line 422: auto fn = [this] { space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f8639436_abcf0b72 PS2, Line 426: std::cerr << "rx stream error! " << bladerf_strerror(status) << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d96b6727_959b8f71 PS2, Line 433: void submit_burst_ts(blade_sample_type *buffer, int len, uint64_t ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/230f92f7_3aad504b PS2, Line 435: //get empty bufer from list 'bufer' may be misspelled - perhaps 'buffer'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/daee3132_12cd9c52 PS2, Line 436: tx_buf_q_type::elem_t rcd; labels should not be indented File Transceiver52M/ms/ipc_specific.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7fb7c401_41d2c058 PS2, Line 38: using blade_sample_type = std::complex<int16_t>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a26047d8_9fcd12e0 PS2, Line 38: using blade_sample_type = std::complex<int16_t>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/17ede36b_383dacf7 PS2, Line 45: auto actual_samples_per_buffer() Bad function definition - auto actual_samples_per_buffer() should probably be auto actual_samples_per_buffer(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cdb8fe55_9cceaf6f PS2, Line 45: auto actual_samples_per_buffer() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1edbfd43_6acb2f8c PS2, Line 49: long get_first_ts() Bad function definition - long get_first_ts() should probably be long get_first_ts(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/56f6f013_b31bd14e PS2, Line 49: long get_first_ts() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/923cb376_3aede780 PS2, Line 53: int readall(blade_sample_type *outaddr) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d73c3400_41ba8b87 PS2, Line 58: int read_n(blade_sample_type *outaddr, int start, int num) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/35bf31f4_5c6e0ac7 PS2, Line 69: using bh_fn_t = std::function<int(dev_buf_t *)>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a0123dd3_8c7aebb1 PS2, Line 69: using bh_fn_t = std::function<int(dev_buf_t *)>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c427cf2c_71380d73 PS2, Line 71: template <typename T> struct ipc_hw { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f35c6428_a0a84447 PS2, Line 71: template <typename T> struct ipc_hw { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f180f9bd_caaab3b1 PS2, Line 76: std::vector<blade_sample_type *> pkt_ptrs; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/833ad6d6_e9c0f660 PS2, Line 76: std::vector<blade_sample_type *> pkt_ptrs; need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ddae2912_94d39308 PS2, Line 76: std::vector<blade_sample_type *> pkt_ptrs; spaces required around that '>' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/72c4e3a9_0cdd319f PS2, Line 76: std::vector<blade_sample_type *> pkt_ptrs; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/86fe3efa_64bcf9a0 PS2, Line 92: bool tuneTx(double freq, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0bdc0968_f424f640 PS2, Line 99: bool tuneRx(double freq, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/21ffd096_9e7a0930 PS2, Line 106: bool tuneRxOffset(double offset, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a80c3a23_382c61be PS2, Line 111: double setRxGain(double dB, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fa7158f6_ab4f12da PS2, Line 119: double setTxGain(double dB, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ab3e3f91_86d8d264 PS2, Line 127: int setPowerAttenuation(int atten, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/862edfd4_68c6de6f PS2, Line 132: int init_device(bh_fn_t rxh, bh_fn_t txh) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7f5d1c2f_c1775b11 PS2, Line 137: void *rx_cb(bh_fn_t burst_handler) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9846cb8d_b8177dc5 PS2, Line 149: dev_buf_t rcd = { t, static_cast<uint32_t>(len), pbuf }; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/366bf6df_88406df1 PS2, Line 149: dev_buf_t rcd = { t, static_cast<uint32_t>(len), pbuf }; spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/097d964a_97ad66b4 PS2, Line 164: auto get_rx_burst_handler_fn(bh_fn_t burst_handler) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4e853008_8d3647c7 PS2, Line 166: auto fn = [this, burst_handler] { space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f238f19b_caecb91f PS2, Line 175: auto get_tx_burst_handler_fn(bh_fn_t burst_handler) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f8bae041_97eb3160 PS2, Line 177: auto fn = [] { space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c1de663d_6fb76c7f PS2, Line 183: void submit_burst_ts(blade_sample_type *buffer, int len, uint64_t ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/770c2ad4_aeb73237 PS2, Line 188: void set_name_aff_sched(const char *name, int cpunum, int schedtype, int prio) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/43062a01_90429084 PS2, Line 193: void signal_start() Bad function definition - void signal_start() should probably be void signal_start(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/74dacd07_f45e55aa PS2, Line 193: void signal_start() open brace '{' following function definitions go on the next line File Transceiver52M/ms/itrq.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/805a658a_a6649f51 PS2, Line 51: template <bool block_read, bool block_write> class spsc_cond_detail { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fef7c90d_14c60f14 PS2, Line 51: template <bool block_read, bool block_write> class spsc_cond_detail { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/eff8d83f_229375fd PS2, Line 52: std::condition_variable cond_r, cond_w; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/49de2144_f4f258d6 PS2, Line 53: std::mutex lr, lw; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a868605c_ef0ccf44 PS2, Line 54: std::atomic_int r_flag, w_flag; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/04e1704e_39d91c98 PS2, Line 56: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6a88df88_769eb0bc PS2, Line 57: explicit spsc_cond_detail() : r_flag(0), w_flag(0) Bad function definition - explicit spsc_cond_detail() should probably be explicit spsc_cond_detail(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b58e43d6_9b6ac868 PS2, Line 65: ssize_t spsc_check_r() Bad function definition - ssize_t spsc_check_r() should probably be ssize_t spsc_check_r(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6a8e76d3_a1f37664 PS2, Line 65: ssize_t spsc_check_r() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/85d36b5a_e907779b PS2, Line 67: std::unique_lock<std::mutex> lk(lr); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e5ee47da_00d44193 PS2, Line 67: std::unique_lock<std::mutex> lk(lr); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6d94a142_56d3773c PS2, Line 67: std::unique_lock<std::mutex> lk(lr); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f02b4a81_8d37af70 PS2, Line 73: ssize_t spsc_check_w() Bad function definition - ssize_t spsc_check_w() should probably be ssize_t spsc_check_w(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ef3bcd20_c001c58d PS2, Line 73: ssize_t spsc_check_w() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f1ab9715_9b3b370a PS2, Line 75: std::unique_lock<std::mutex> lk(lw); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bce293ab_08bcb368 PS2, Line 75: std::unique_lock<std::mutex> lk(lw); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3021a7d5_30cbc351 PS2, Line 75: std::unique_lock<std::mutex> lk(lw); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8ed5d007_c1f0d1c6 PS2, Line 81: void spsc_notify_r() Bad function definition - void spsc_notify_r() should probably be void spsc_notify_r(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4ebdfce0_a0c9f8c5 PS2, Line 81: void spsc_notify_r() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/afa06b44_acfcbe05 PS2, Line 83: std::unique_lock<std::mutex> lk(lr); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f6d7ef54_ff2a5b75 PS2, Line 83: std::unique_lock<std::mutex> lk(lr); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6b982ee8_a8206daa PS2, Line 83: std::unique_lock<std::mutex> lk(lr); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/99ad0c14_8eaff6b7 PS2, Line 87: void spsc_notify_w() Bad function definition - void spsc_notify_w() should probably be void spsc_notify_w(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e0751689_02967fad PS2, Line 87: void spsc_notify_w() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/65837489_e502f78b PS2, Line 89: std::unique_lock<std::mutex> lk(lw); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e527369c_fe214f37 PS2, Line 89: std::unique_lock<std::mutex> lk(lw); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2bef5700_65c6d88e PS2, Line 89: std::unique_lock<std::mutex> lk(lw); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4f4f2f1c_9f04cdd8 PS2, Line 96: template <bool block_read, bool block_write> class spsc_efd_detail { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7a2e9db9_40691450 PS2, Line 96: template <bool block_read, bool block_write> class spsc_efd_detail { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8a084cf8_22586c71 PS2, Line 99: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e36864a5_bf9a860d PS2, Line 100: explicit spsc_efd_detail() Bad function definition - explicit spsc_efd_detail() should probably be explicit spsc_efd_detail(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3b8e8b43_a53c4989 PS2, Line 111: ssize_t spsc_check_r() Bad function definition - ssize_t spsc_check_r() should probably be ssize_t spsc_check_r(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9dfd037b_148bb38d PS2, Line 111: ssize_t spsc_check_r() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/38359cc0_9b6f5cf4 PS2, Line 116: ssize_t spsc_check_w() Bad function definition - ssize_t spsc_check_w() should probably be ssize_t spsc_check_w(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a7edd4f2_0342b6a3 PS2, Line 116: ssize_t spsc_check_w() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3bce982f_8c808462 PS2, Line 121: void spsc_notify_r() Bad function definition - void spsc_notify_r() should probably be void spsc_notify_r(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/26303265_6b7d41dd PS2, Line 121: void spsc_notify_r() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0f885732_2d375112 PS2, Line 126: void spsc_notify_w() Bad function definition - void spsc_notify_w() should probably be void spsc_notify_w(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b8d01d9e_fd0b6db4 PS2, Line 126: void spsc_notify_w() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/626489da_c0b10d5a PS2, Line 131: int get_r_efd() Bad function definition - int get_r_efd() should probably be int get_r_efd(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1f51f435_62c6e067 PS2, Line 131: int get_r_efd() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f687d017_f12730e9 PS2, Line 135: int get_w_efd() Bad function definition - int get_w_efd() should probably be int get_w_efd(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/95a220c7_88e5ca8a PS2, Line 135: int get_w_efd() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ad6294e0_6ca0bcdd PS2, Line 141: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write, template <bool, bool> class T> spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/807a4bda_7ecc3b84 PS2, Line 141: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write, template <bool, bool> class T> spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b284723d_9b7d702a PS2, Line 141: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write, template <bool, bool> class T> spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0d31d197_578aebe0 PS2, Line 141: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write, template <bool, bool> class T> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/53a4925f_75a64bed PS2, Line 142: class spsc : public T<block_read, block_write> { spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/87dafb2b_31eeb866 PS2, Line 142: class spsc : public T<block_read, block_write> { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2ea72a85_e1de608a PS2, Line 144: std::atomic<unsigned int> readptr; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/178e37b0_4381b5c8 PS2, Line 144: std::atomic<unsigned int> readptr; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/86d554c2_c87ccd7f PS2, Line 144: std::atomic<unsigned int> readptr; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b619e4d3_d9516d94 PS2, Line 145: std::atomic<unsigned int> writeptr; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/355f16db_c4d92f19 PS2, Line 145: std::atomic<unsigned int> writeptr; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bdb36439_6de575ea PS2, Line 145: std::atomic<unsigned int> writeptr; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/20b0c12e_a8dd4d78 PS2, Line 149: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1b7674ce_23faa831 PS2, Line 150: using base_t = T<block_read, block_write>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/39f48482_45487798 PS2, Line 150: using base_t = T<block_read, block_write>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7e0c2e7b_8dfb546f PS2, Line 152: explicit spsc() : readptr(0), writeptr(0) Bad function definition - explicit spsc() should probably be explicit spsc(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1afbd55d_2a08ba4a PS2, Line 163: bool spsc_push(const ELEM *elem) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f0512508_25083ab7 PS2, Line 170: base_t::spsc_check_w(); /* blocks, ensures next (!) call succeeds */ labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/95ae9c67_15be7a12 PS2, Line 176: base_t::spsc_notify_r(); /* fine after release */ labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6f225590_a319e27c PS2, Line 183: bool spsc_pop(ELEM *elem) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b9c5bc56_5d91b150 PS2, Line 195: base_t::spsc_notify_w(); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ab87e5ef_e0507192 PS2, Line 202: ssize_t spsc_prep_pop() Bad function definition - ssize_t spsc_prep_pop() should probably be ssize_t spsc_prep_pop(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d6042f9b_14039555 PS2, Line 202: ssize_t spsc_prep_pop() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/324e1d15_d2656793 PS2, Line 210: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write> spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3ca1683b_15d9a4a1 PS2, Line 210: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/68512c8d_3520e851 PS2, Line 211: class spsc_evfd : public spsc_detail::spsc<SZ, ELEM, block_read, block_write, spsc_detail::spsc_efd_detail> {}; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5d8c2da4_33d95ff3 PS2, Line 211: class spsc_evfd : public spsc_detail::spsc<SZ, ELEM, block_read, block_write, spsc_detail::spsc_efd_detail> {}; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9ab241d7_afdcabb3 PS2, Line 212: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write> spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5a6e13f4_af7c4a98 PS2, Line 212: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/79004e00_c6f9d6fe PS2, Line 213: class spsc_cond : public spsc_detail::spsc<SZ, ELEM, block_read, block_write, spsc_detail::spsc_cond_detail> {}; adding a line without newline at end of file Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/de4a1b43_e055b541 PS2, Line 213: class spsc_cond : public spsc_detail::spsc<SZ, ELEM, block_read, block_write, spsc_detail::spsc_cond_detail> {}; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b0ab1582_3892f89f PS2, Line 213: class spsc_cond : public spsc_detail::spsc<SZ, ELEM, block_read, block_write, spsc_detail::spsc_cond_detail> {}; spaces required around that '>' (ctx:VxW) File Transceiver52M/ms/logging.cpp: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/865eb3a0_2ae3b1f1 PS2, Line 83: .enabled = 0, trailing whitespace File Transceiver52M/ms/ms.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/95b56a27_964f7bdc PS2, Line 34: #define BASET blade_hw<ms_trx> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b994966d_a92afde8 PS2, Line 34: #define BASET blade_hw<ms_trx> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/465213ec_dfc467c8 PS2, Line 37: #define BASET uhd_hw<ms_trx> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8c45b81b_c860676f PS2, Line 37: #define BASET uhd_hw<ms_trx> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2999fa2c_4e8a2332 PS2, Line 40: #define BASET ipc_hw<ms_trx> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c580a354_2cff24aa PS2, Line 40: #define BASET ipc_hw<ms_trx> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/76a89e4a_740a5bfe PS2, Line 52: template <typename T> void clamp_array(T *start2, unsigned int len, T max) spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c79096f7_b61f987b PS2, Line 52: template <typename T> void clamp_array(T *start2, unsigned int len, T max) spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/27d4b37e_b97de5f6 PS2, Line 52: template <typename T> void clamp_array(T *start2, unsigned int len, T max) need consistent spacing around '*' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/07ce88e6_5d4885ef PS2, Line 60: template <typename DST_T, typename SRC_T, typename ST> spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d5dbd9e2_9d12e084 PS2, Line 60: template <typename DST_T, typename SRC_T, typename ST> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9df6e966_c3f44a50 PS2, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f89128a9_539a1057 PS2, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/37400f40_a8d674d8 PS2, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; spaces required around that '>' (ctx:OxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/78bcaffc_bd47c9bd PS2, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/dcc2b7d2_bd605cf7 PS2, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/936da6d0_23400de3 PS2, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b99c338f_f485964f PS2, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/aff69de4_6e883f1f PS2, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; spaces required around that '>' (ctx:OxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6228cc7e_7a0040bd PS2, Line 66: template <typename DST_T, typename SRC_T> void convert_and_scale_default(void *dst, void *src, unsigned int src_len) spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3d17ae6b_4b9add35 PS2, Line 66: template <typename DST_T, typename SRC_T> void convert_and_scale_default(void *dst, void *src, unsigned int src_len) spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f58bf6b0_a16da5fc PS2, Line 68: return convert_and_scale<DST_T, SRC_T>(dst, src, src_len, SAMPLE_SCALE_FACTOR); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/01a68954_c70951df PS2, Line 68: return convert_and_scale<DST_T, SRC_T>(dst, src, src_len, SAMPLE_SCALE_FACTOR); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4d4e2fe4_7eacb915 PS2, Line 75: GSM::Time gsmts; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3e183f15_486ceef0 PS2, Line 82: using rx_queue_t = spsc_cond<8 * NUM_RXQ_FRAMES, one_burst, true, true>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7c908880_6f49fd8a PS2, Line 82: using rx_queue_t = spsc_cond<8 * NUM_RXQ_FRAMES, one_burst, true, true>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1c6c1024_b253a743 PS2, Line 87: std::ostream null_stream; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1a7a6219_818a8466 PS2, Line 89: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/96e2aa27_b6985563 PS2, Line 90: dummylog() : null_stream(this){}; space required before the open brace '{' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7f32615b_7b029abe PS2, Line 92: std::ostream &operator()() need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b0fc09b7_b9591198 PS2, Line 92: std::ostream &operator()() labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a0e3a0f8_cea448be PS2, Line 104: GSM::Time global_time_keeper; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d5b522b7_87dd95e9 PS2, Line 106: std::mutex m; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d7bac078_b76c78cd PS2, Line 108: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4b0e0ff2_de040450 PS2, Line 113: void set(GSM::Time t, int64_t ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7b10767e_328525e6 PS2, Line 115: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f4e0f3d0_4f2bf30d PS2, Line 115: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2cd5f698_1d379f6d PS2, Line 115: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8855f4ed_8cbc1a9a PS2, Line 119: void inc_both() Bad function definition - void inc_both() should probably be void inc_both(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4dda287c_eede24d7 PS2, Line 119: void inc_both() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/55b366db_4731de88 PS2, Line 121: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8f3fa857_c7204759 PS2, Line 121: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3575f302_0ceb7f4a PS2, Line 121: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/19fb5fc7_54b5a7dd PS2, Line 125: void inc_and_update(int64_t new_ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8687152d_812c5c28 PS2, Line 127: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/dbb94964_31ebb703 PS2, Line 127: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/decee943_d584f6e2 PS2, Line 127: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9309d335_cb849bc6 PS2, Line 132: void inc_and_update_safe(int64_t new_ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f8cb6ab3_5db8e5ca PS2, Line 134: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ba72a718_9745abf0 PS2, Line 134: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/97162c89_9332e1b8 PS2, Line 134: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f28b6a2a_236b789f PS2, Line 142: void dec_by_one() Bad function definition - void dec_by_one() should probably be void dec_by_one(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d427cb21_85a48306 PS2, Line 142: void dec_by_one() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/93dfe7e0_fbe7d794 PS2, Line 144: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/39c1f362_52438e48 PS2, Line 144: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4cff87fe_95f9440a PS2, Line 144: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/412d55c6_c341ae04 PS2, Line 148: auto get_ts() Bad function definition - auto get_ts() should probably be auto get_ts(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/82ced194_e0c514d9 PS2, Line 148: auto get_ts() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b4d31dae_ee0c44bc PS2, Line 150: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c8ce3124_f3dd8a7c PS2, Line 150: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8067df9c_9ed9cde3 PS2, Line 150: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b271f9c3_9b70b2a5 PS2, Line 153: auto gsmtime() Bad function definition - auto gsmtime() should probably be auto gsmtime(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f1c146e2_62fcec8d PS2, Line 153: auto gsmtime() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9419931a_da76f90b PS2, Line 155: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fe0c13db_a94a7c2a PS2, Line 155: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/71490996_77a53e2d PS2, Line 155: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fed0b9bb_b1071370 PS2, Line 158: void get_both(GSM::Time *t, int64_t *ts) need consistent spacing around '*' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f66bdf06_0bdd98aa PS2, Line 158: void get_both(GSM::Time *t, int64_t *ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cd45cce2_2dbd107d PS2, Line 160: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a50abdf1_6538f769 PS2, Line 160: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2e1fbdad_c0e174f9 PS2, Line 160: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5ff5f6c5_fe629dff PS2, Line 166: using ts_hitter_q_t = spsc_cond<64, GSM::Time, true, false>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/10bf98f8_17e81be0 PS2, Line 166: using ts_hitter_q_t = spsc_cond<64, GSM::Time, true, false>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/414b11d5_73637894 PS2, Line 176: std::thread rx_task; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9755754d_6ee983c3 PS2, Line 177: std::thread tx_task; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/aef4a099_c39f761e PS2, Line 178: std::thread *calcrval_task; need consistent spacing around '*' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7fd40f7c_f0a69952 PS2, Line 178: std::thread *calcrval_task; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4a8eb9f3_5f716e79 PS2, Line 189: std::atomic<bool> rcv_done; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/89a49d0c_2b972ac8 PS2, Line 189: std::atomic<bool> rcv_done; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cb61630d_1f2a8513 PS2, Line 189: std::atomic<bool> rcv_done; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ce6b2be8_09ca15be PS2, Line 190: std::atomic<bool> sch_thread_done; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b3befff9_d7a44d44 PS2, Line 190: std::atomic<bool> sch_thread_done; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e4c50341_5ae7c582 PS2, Line 190: std::atomic<bool> sch_thread_done; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d6f2ae87_ea9e5531 PS2, Line 197: void start(); Bad function definition - void start() should probably be void start(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/31139cf3_7af35fa6 PS2, Line 198: std::atomic<bool> upper_is_ready; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/32feaa6a_19ccb291 PS2, Line 198: std::atomic<bool> upper_is_ready; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9f8289a1_ed97aafd PS2, Line 198: std::atomic<bool> upper_is_ready; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d3d91393_24acc846 PS2, Line 201: bool handle_sch_or_nb(); Bad function definition - bool handle_sch_or_nb() should probably be bool handle_sch_or_nb(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1d3072fe_f11e2486 PS2, Line 207: int init_device(); Bad function definition - int init_device() should probably be int init_device(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/53054c84_6b209720 PS2, Line 208: int init_dev_and_streams(); Bad function definition - int init_dev_and_streams() should probably be int init_dev_and_streams(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3eb711f4_a3666ea2 PS2, Line 209: void stop_threads(); Bad function definition - void stop_threads() should probably be void stop_threads(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7441feab_a3df5f5d PS2, Line 211: void *tx_cb(); Bad function definition - void *tx_cb() should probably be void *tx_cb(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/68a4e779_813e745c PS2, Line 212: void maybe_update_gain(one_burst &brst); need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5b4ccf39_d744d0b6 PS2, Line 225: bh_fn_t rx_bh(); Bad function definition - bh_fn_t rx_bh() should probably be bh_fn_t rx_bh(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1444e982_1f4c9a00 PS2, Line 226: bh_fn_t tx_bh(); Bad function definition - bh_fn_t tx_bh() should probably be bh_fn_t tx_bh(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e48b00b1_0864b183 PS2, Line 229: void set_ta(int val) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a10ffe2c_1829813d PS2, Line 235: void set_name_aff_sched(const char *name, int cpunum, int schedtype, int prio) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/074d44a2_7588e3c5 PS2, Line 240: void set_name_aff_sched(std::thread::native_handle_type h, const char *name, int cpunum, int schedtype, open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/305bab73_b4ccbbb7 PS2, Line 252: std::cerr << name << " affinity: errreur! " << std::strerror(errno); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4084a0d8_e72349a5 PS2, Line 260: std::cerr << name << " sched: errreur! " << std::strerror(errno); labels should not be indented File Transceiver52M/ms/ms_rx_burst.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/210b7aeb_896c1b97 PS2, Line 25: void rcv_bursts_test(rx_queue_t *q, unsigned int *tsc, int scale); adding a line without newline at end of file File Transceiver52M/ms/ms_upper.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/316c15d2_0b712f37 PS2, Line 44: bool driveControl(); Bad function definition - bool driveControl() should probably be bool driveControl(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3f414477_66610c77 PS2, Line 45: void driveReceiveFIFO(); Bad function definition - void driveReceiveFIFO() should probably be void driveReceiveFIFO(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4ebb43ae_7155557d PS2, Line 46: void driveTx(); Bad function definition - void driveTx() should probably be void driveTx(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8bcd6f3d_f12fd28e PS2, Line 48: bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset) __attribute__((optnone)); need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7b28085a_e533507a PS2, Line 48: bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset) __attribute__((optnone)); need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/18bc8f38_68b2d62d PS2, Line 48: bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset) __attribute__((optnone)); need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3ec9be35_c7cfb2e5 PS2, Line 48: bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset) __attribute__((optnone)); function definition argument 'int' should also have an identifier name Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/46bb9bb1_a656a05f PS2, Line 48: bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset) __attribute__((optnone)); function definition argument 'int' should also have an identifier name Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d9c98d55_7e259344 PS2, Line 50: std::thread thr_control, thr_rx, thr_tx; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/20883957_2648112b PS2, Line 52: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/89f66281_6e2802d9 PS2, Line 53: void start_threads(); Bad function definition - void start_threads() should probably be void start_threads(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/452a6bf8_955ff2d1 PS2, Line 54: void start_lower_ms(); Bad function definition - void start_lower_ms() should probably be void start_lower_ms(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0f9736d9_63ed5b14 PS2, Line 56: upper_trx(){}; space required before the open brace '{' File Transceiver52M/ms/sch.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/561a1011_4fe3fd9a PS2, Line 130: int gsm_fcch_check_ts(int ts, int fn) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3db20e4f_85f12762 PS2, Line 134: int gsm_sch_check_ts(int ts, int fn) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f6e7ae78_e412c5e6 PS2, Line 205: #if 1 Consider removing the #if 1 and its #endif Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fd1437bb_79fc71a4 PS2, Line 210: float a, b, c, d, ang, avg = 0.0f; 'ang' may be misspelled - perhaps 'and'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/da78706f_1701e0c6 PS2, Line 235: ang = b - a; 'ang' may be misspelled - perhaps 'and'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c00205cf_3287c219 PS2, Line 237: if (ang > M_PI) 'ang' may be misspelled - perhaps 'and'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/aed017f7_1fa05b5a PS2, Line 238: ang -= 2 * M_PI; 'ang' may be misspelled - perhaps 'and'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d5e537e0_045f80c7 PS2, Line 239: else if (ang < -M_PI) 'ang' may be misspelled - perhaps 'and'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ae124ede_440eeb28 PS2, Line 240: ang += 2 * M_PI; 'ang' may be misspelled - perhaps 'and'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5db93485_e6721615 PS2, Line 242: avg += ang; 'ang' may be misspelled - perhaps 'and'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5d20a7cc_d38ab782 PS2, Line 259: void pinv(int P, int8_t* r, int8_t* s, int L1, int L2) { "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/84ce0cda_61978db2 PS2, Line 259: void pinv(int P, int8_t* r, int8_t* s, int L1, int L2) { "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b16732fc_c85145b0 PS2, Line 259: void pinv(int P, int8_t* r, int8_t* s, int L1, int L2) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d3664e39_195c68a8 PS2, Line 270: float ac_sum_with_lag( complex float* in, int lag, int offset, int N) { "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8cba79be_bbf76d67 PS2, Line 270: float ac_sum_with_lag( complex float* in, int lag, int offset, int N) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a0c09973_6aa5e9cb PS2, Line 270: float ac_sum_with_lag( complex float* in, int lag, int offset, int N) { space prohibited after that open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/62078d28_3a1b6a28 PS2, Line 314: static __attribute__((constructor)) void init() Bad function definition - void init() should probably be void init(void) File Transceiver52M/ms/uhd_specific.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/242c1c9b_e9c1a5d4 PS2, Line 35: using blade_sample_type = std::complex<int16_t>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/75f01dec_1fe9c42c PS2, Line 35: using blade_sample_type = std::complex<int16_t>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9f043012_a17c445f PS2, Line 41: uhd::rx_metadata_t *md; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f3881609_47e19272 PS2, Line 43: auto actual_samples_per_buffer() Bad function definition - auto actual_samples_per_buffer() should probably be auto actual_samples_per_buffer(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8d6ab496_9d7bcf64 PS2, Line 43: auto actual_samples_per_buffer() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bde09a4b_2662aa77 PS2, Line 47: long get_first_ts() Bad function definition - long get_first_ts() should probably be long get_first_ts(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fa19381d_274e5151 PS2, Line 47: long get_first_ts() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ee3156f2_93f7671b PS2, Line 51: int readall(blade_sample_type *outaddr) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/24443202_55319b90 PS2, Line 56: int read_n(blade_sample_type *outaddr, int start, int num) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a9316799_99b4a15f PS2, Line 67: using bh_fn_t = std::function<int(dev_buf_t *)>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f58a521a_7a8bda6d PS2, Line 67: using bh_fn_t = std::function<int(dev_buf_t *)>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/046d1195_f9c65e4d PS2, Line 69: template <typename T> struct uhd_hw { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7317e6fd_37c50faf PS2, Line 69: template <typename T> struct uhd_hw { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/294d445e_5493aa72 PS2, Line 70: uhd::usrp::multi_usrp::sptr dev; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/08daf9f0_135e736a PS2, Line 71: uhd::rx_streamer::sptr rx_stream; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fa3da926_9d8cc89b PS2, Line 72: uhd::tx_streamer::sptr tx_stream; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7e350667_cbcaf3a7 PS2, Line 74: std::vector<blade_sample_type *> pkt_ptrs; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8d4030cb_ec8e415b PS2, Line 74: std::vector<blade_sample_type *> pkt_ptrs; need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e9ef2b4f_5482524a PS2, Line 74: std::vector<blade_sample_type *> pkt_ptrs; spaces required around that '>' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d5cef973_45437a6b PS2, Line 74: std::vector<blade_sample_type *> pkt_ptrs; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e1163c37_6a84399b PS2, Line 90: void close_device() Bad function definition - void close_device() should probably be void close_device(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fa9dcd65_ee9fa117 PS2, Line 90: void close_device() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3d8c4aa0_e9e6be7a PS2, Line 95: bool tuneTx(double freq, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c9c48af9_cf912c56 PS2, Line 102: bool tuneRx(double freq, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/aa37e21e_69b72f03 PS2, Line 109: bool tuneRxOffset(double offset, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fdd81261_9285956e PS2, Line 114: double setRxGain(double dB, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8de6c3a0_10c428e5 PS2, Line 122: double setTxGain(double dB, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/71a36148_e4045277 PS2, Line 130: int setPowerAttenuation(int atten, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/68a4e6a5_5e7cb5f5 PS2, Line 135: int init_device(bh_fn_t rxh, bh_fn_t txh) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/72d9156b_47753f88 PS2, Line 145: std::string args = {}; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/409406e3_4f41e69e PS2, Line 148: std::cout << "Using Device: " << dev->get_pp_string() << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/03560bfe_1c4a4cc5 PS2, Line 153: uhd::tune_request_t tune_request(freq, 0); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/af64fcbf_1fbd3bda PS2, Line 162: std::this_thread::sleep_for(std::chrono::milliseconds(lock_delay_ms)); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ef84a8d1_cc7d0583 PS2, Line 164: uhd::stream_args_t stream_args("sc16", "sc16"); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/66dfbdd0_7c78e9e4 PS2, Line 166: uhd::stream_args_t stream_args2("sc16", "sc16"); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b214a91a_09dcb8ef PS2, Line 177: void *rx_cb(bh_fn_t burst_handler) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cc9f9cf1_817bb6f3 PS2, Line 182: uhd::rx_metadata_t md; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/07327356_0977f702 PS2, Line 186: std::cerr << boost::format("Timeout while streaming") << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4c37ee65_74c183a2 PS2, Line 190: std::cerr << boost::format("Got an overflow indication\n") << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5e309200_00d118c7 PS2, Line 194: std::cerr << str(boost::format("Receiver error: %s") % md.strerror()); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/24c2261c_cd13a929 PS2, Line 209: auto get_rx_burst_handler_fn(bh_fn_t burst_handler) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/730873d6_6c0e7484 PS2, Line 211: auto fn = [this, burst_handler] { space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6bdabc96_9aebecc6 PS2, Line 214: uhd::stream_cmd_t stream_cmd(uhd::stream_cmd_t::STREAM_MODE_START_CONTINUOUS); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fed190f4_a987f005 PS2, Line 225: auto get_tx_burst_handler_fn(bh_fn_t burst_handler) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5f756c13_048d4a3a PS2, Line 227: auto fn = [] { space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cc252526_f5505ce7 PS2, Line 232: void submit_burst_ts(blade_sample_type *buffer, int len, uint64_t ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4f986189_730186cd PS2, Line 234: uhd::tx_metadata_t m = {}; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/34540695_3147c90b PS2, Line 239: std::vector<void *> ptrs(1, buffer); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a8ecf8a4_4f4c060a PS2, Line 239: std::vector<void *> ptrs(1, buffer); need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d273c053_0a1546df PS2, Line 239: std::vector<void *> ptrs(1, buffer); spaces required around that '>' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/703a0df4_e7c8b909 PS2, Line 239: std::vector<void *> ptrs(1, buffer); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/01e75ac1_3e130836 PS2, Line 243: uhd::async_metadata_t async_md; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/dce1bfd1_67a1843a PS2, Line 248: std::cout << (tx_ack ? "yay" : "nay") << " " << async_md.time_spec.to_ticks(rxticks) << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/49aca56e_59596b2a PS2, Line 251: }; adding a line without newline at end of file -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30416 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I36c65a8c725c4da76dc70006cd96b0a2b6878e84 Gerrit-Change-Number: 30416 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen &lt;ewild(a)sysmocom.de&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: Hoernchen &lt;ewild(a)sysmocom.de&gt; Gerrit-Comment-Date: Thu, 01 Dec 2022 11:24:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment