Attention is currently required from: laforge. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/39225?usp=email ) Change subject: global_platform: fix usage of the Key Version Number (kvn) ...................................................................... Patch Set 2: (1 comment) File pySim/global_platform/scp.py: https://gerrit.osmocom.org/c/pysim/+/39225/comment/f71be127_ae786cb1?usp=em… : PS2, Line 230: kvn_ranges = [[0x00, 0x00], [0x01, 0x01], [0x20, 0x2f], [0x70, 0x70]] This is something I do not fully understand, why do we have a hard restriction on the KVN range? Is there any spec that explicitly restricts the ranges? Apparantly it is not uncommon to use a custom range/kvn (we do it). Maybe we should only print a warning and not throw an exception when the range is violated? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39225?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I42be2438c7f199b238f2ec7a9434cec5393210a7 Gerrit-Change-Number: 39225 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 03 Jan 2025 10:30:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No