Attention is currently required from: fixeria, laforge, pespin.

jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35391?usp=email )

Change subject: Add LLC and HLC transcoding to MNCC transcoding functions ......................................................................

Patch Set 3:

(2 comments)

Patchset:

PS3:

I guess I agree in general, but I'm not aware we've so far developed some kind of standard/generic " […]

The idea for choosing a structure for the new IEs was to change the data buffer into actually parsed fields later. There is no need for that on the network side, but on the mobile side, like osmocom-bb.

Expanding MNCC potocol by adding new IEs to the end of the existing MNCC message would make sense, if even more IEs would follow. I would not put new effort in MNCC development, because it is unlikely that it needs to be expanded in the future.

File include/osmocom/gsm/mncc.h:

https://gerrit.osmocom.org/c/libosmocore/+/35391/comment/eca01449_a4d30c13 PS3, Line 37: int len;

this should be unsigned. And probably uint8_t.

This makes sense.