Attention is currently required from: fixeria, laforge. falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-abis/+/38138?usp=email ) Change subject: trau2rtp FR & EFR: fix uninitialized memory bug ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I really don't like this idea. It is nothing but a weird quirk of the particular code implementation used for FRv1 and EFR (but not for HRv1 or CSD) in that the code only sets bits to 1 but doesn't directly set them to 0. Clean interfaces between components (APIs) should be based on the good abstract design, not retro-defined around oddball quirks of a particular legacy code implementation. I struggle to think of any widely known API where the result of a function is wrong unless the caller presets the output buffer to some particular value or byte pattern. You should also note that the unit test in the following patch fails unless the present patch is applied - that's how I caught this bug in the first place. -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/38138?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I6e6693e096b920a973c8cc627e94884099d004b5 Gerrit-Change-Number: 38138 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Sep 2024 06:24:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>