Attention is currently required from: fixeria.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31795 )
Change subject: rsl_rx_ipac_XXcx: parse csd_fmt_d/ir ......................................................................
Patch Set 1:
(1 comment)
File src/common/rsl.c:
https://gerrit.osmocom.org/c/osmo-bts/+/31795/comment/6b57347b_1aaaf529 PS1, Line 2772: csd_fmt_d = *csd_fmt & 0xf;
Are you sure this is correct? In the previous patch I see: […]
In OsmoBSC I construct it like this, and it shows up correctly in wireshark:
``` ret = RSL_IPAC_RTP_CSD_TRAU_BTS; ret |= RSL_IPAC_RTP_CSD_IR_8k << 5; ```
So it needs to be switched around in the doc, and >> 4 needs to be used as you point out above. I've updated both patches.