Attention is currently required from: pespin.

Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/32764 )

Change subject: devices: add freq/gain override for uhd ......................................................................

Patch Set 11:

(3 comments)

Patchset:

PS11: Why would I hide the fixed freqs setting that are initialized once as configured in a function that is dynamically called at some random time depending on incoming messages? The freq override is and should be completely independent of any interaction that might or might not be happening.

File Transceiver52M/device/uhd/UHDDevice.cpp:

https://gerrit.osmocom.org/c/osmo-trx/+/32764/comment/41d5be83_99f7f02c PS5, Line 635: if (cfg->overrides.dl_freq_override) {

why are you doing it here instead of the place where the freq/gain is supposed to be updated?

Done

https://gerrit.osmocom.org/c/osmo-trx/+/32764/comment/20068196_163d38e6 PS5, Line 1013: if (cfg->overrides.dl_freq_override || cfg->overrides.ul_freq_override)

I would expected the overwritten frequency to be set here?

Done