Change in osmo-tetra[master]: Created tuntap.h to allow for proper use of tun_alloc in tetra_llc.c - gerrit-log

19 Jul 2022

Attention is currently required from: laforge.
wbokslag has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-tetra/+/28592 )

Change subject: Created tuntap.h to allow for proper use of tun_alloc in tetra_llc.c
......................................................................

Patch Set 1:

(1 comment)

File src/tuntap.h:

https://gerrit.osmocom.org/c/osmo-tetra/+/28592/comment/fc3aad56_44497d1c 
PS1, Line 1: #ifndef TUNTAP_H
...
  I think "#pragma once" should be used for
all code developed in the last decade, but it's not critical if you don't want to
change it. We can always clean that up later. 
It seems best to me to be consistent across the osmo-tetra h-files, and all use the
classic ifdef method. I'd suggest to leave the commit as-is.

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/28592
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-tetra
Gerrit-Branch: master
Gerrit-Change-Id: If920c15e4dafb48d5df70ce20532ecb19bd01ee3
Gerrit-Change-Number: 28592
Gerrit-PatchSet: 1
Gerrit-Owner: wbokslag &lt;w.bokslag(a)midnightblue.nl&gt;
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge &lt;laforge(a)osmocom.org&gt;
Gerrit-Attention: laforge &lt;laforge(a)osmocom.org&gt;
Gerrit-Comment-Date: Tue, 19 Jul 2022 08:30:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge &lt;laforge(a)osmocom.org&gt;
Gerrit-MessageType: comment