Attention is currently required from: fixeria. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27905 ) Change subject: bsc: TC_emerg_premption: cosmetic ...................................................................... Patch Set 1: (1 comment) File bsc/BSC_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27905/comment/ebf0314f_35f1… PS1, Line 8976: if (first_tch != rx_rsl.ies[0].body.chan_nr) { debatable, because this check can never trigger. We occupy all lchans, then free one and again activate that one. Just before, it wasn't as obvious that it will be the same one. We would take the chan_nr from the RSL, but it *has* to be the same first_tch. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27905 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0c540d76eedfd4115b410921bf5a0b6c2d00b5c2 Gerrit-Change-Number: 27905 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 24 Apr 2022 20:17:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment