Attention is currently required from: pespin.
keith has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-hlr/+/30699
)
Change subject: Vty: Add missing param to config write
......................................................................
Patch Set 1:
(1 comment)
File src/dgsm_vty.c:
https://gerrit.osmocom.org/c/osmo-hlr/+/30699/comment/ba1285a9_0b4147cc
PS1, Line 479: vty_out(vty, " timeout %u%s",
are you sure you are not missing the "mdns"
prefix here?
yes, I'm sure, see below, Do you think the timeout should have this
prefix?
DEFUN(cfg_mslookup_client_timeout,
cfg_mslookup_client_timeout_cmd,
"timeout <1-100000>",
OsmoHLR(config-mslookup-client)#
help Description of the interactive help system
list Print command list
show Show running system information
write Write running configuration to memory, network, or terminal
exit Exit current mode and down to previous mode
end End current mode and change to enable mode.
timeout How long should the mslookup client wait for remote responses before
evaluating received results
mdns Multicast DNS related configuration
no Negate a command or set its defaults
gateway-proxy Configure a fixed IP address to send all GSUP requests for unknown IMSIs
to, without invoking a lookup for IMSI
--
To view, visit
https://gerrit.osmocom.org/c/osmo-hlr/+/30699
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: Ibb60e74a0803f05f37ac13ca529d77b4cb736025
Gerrit-Change-Number: 30699
Gerrit-PatchSet: 1
Gerrit-Owner: keith <keith(a)rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 19 Dec 2022 19:06:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment