Attention is currently required from: pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/32961 to look at the new patch set (#3). Change subject: gsm0503_tch_hr_encode(): accept both TS101318 and RFC5993 payloads ...................................................................... gsm0503_tch_hr_encode(): accept both TS101318 and RFC5993 payloads The original design of gsm0503_tch_hr_{en,de}code() functions contains a mistake in that a pseudo-RFC5993 format was chosen for HR codec frame input and output, instead of "pure" (agnostic to outer RTP encoding) form of 14 bytes. We would like to change this design so that we can feed pure 14-byte HR codec frames to the channel coding function and get such frames back from the channel decoding function - however, we cannot break libosmocoding API for existing users. In the encoding direction, make the new format our preferred one, but support the extra-octet format for backward compatibility. Related: OS#5688 Change-Id: I13eaad366f9f68615b9e9e4a5f87396a0e9dea0f --- M src/coding/gsm0503_coding.c 1 file changed, 27 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/61/32961/3 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32961 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I13eaad366f9f68615b9e9e4a5f87396a0e9dea0f Gerrit-Change-Number: 32961 Gerrit-PatchSet: 3 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset