Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33457 ) Change subject: osmo-bts-sysmo: mute PHY until OML is ready ...................................................................... Patch Set 8: (1 comment) File src/osmo-bts-sysmo/l1_if.c: https://gerrit.osmocom.org/c/osmo-bts/+/33457/comment/b1652469_92d4f055 PS7, Line 1271: oml_mo_rf_lock_chg(&trx->mo, fl1h->last_rf_mute, 0); Do you mean: verify that it does not go into this code path before OML is established? In my testing it did not. As I understand it would only go there if l1 failed to set the RF to muted (in which case it's right to keep the RF Active LED on). When OsmoBSC is not running: - glows shortly on start up - LED stays off until OsmoBSC is started and OML is established - when shutting down OsmoBSC, the LED goes off again - when starting OsmoBSC again, the LED goes on When OsmoBSC is running before OsmoBTS is running, the LED goes on and stays on. => working as expected -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33457 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ia1769f952fa787202a442a33db5ed4a1f7cbe9c3 Gerrit-Change-Number: 33457 Gerrit-PatchSet: 8 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 26 Jun 2023 15:58:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment