Attention is currently required from: fixeria.
jolly has posted comments on this change. (
https://gerrit.osmocom.org/c/osmocom-bb/+/35583?usp=email )
Change subject: mobile: implement sending CSD data over UNIX socket
......................................................................
Patch Set 5:
(1 comment)
File src/host/layer23/src/mobile/tch_data_sock.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/35583/comment/5b8bfdbf_1e44c40f
PS5, Line 168: osmo_fd_read_disable(&state->listen_bfd);
You disable read of socket listening fd. This would cause any other client connection to
lock until read is enabled again. Maybe you want to reject any other connection instead by
closing the socket, while there is already a socket client connection.
--
To view, visit
https://gerrit.osmocom.org/c/osmocom-bb/+/35583?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Id054af7b3d9d0a41715f7981deb420f6e09bf30c
Gerrit-Change-Number: 35583
Gerrit-PatchSet: 5
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 19 Jan 2024 09:09:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment