Attention is currently required from: laforge, neels. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-iuh/+/38946?usp=email ) Change subject: iu_client: add ranap_iu_page_cs2/ranap_iu_page_ps2 ...................................................................... Patch Set 13: (7 comments) Patchset: PS13: yes I know, but I didn't want to have another major rewrite of code atm. Fixing the current code to be good enough here. File src/iu_client.c: https://gerrit.osmocom.org/c/osmo-iuh/+/38946/comment/8f379dce_eb85152a?usp… : PS13, Line 842: LOGL_ERROR yes, but I think error is a little bit harsh, only when a client isn't reachable. Both cs and ps will use now INFO https://gerrit.osmocom.org/c/osmo-iuh/+/38946/comment/877860a6_2df692d1?usp… : PS13, Line 869: int ranap_iu_page_cs2(const char *imsi, const uint32_t *tmsi, const struct osmo_location_area_id *lai) I added a comment, but still not describing what's the difference. https://gerrit.osmocom.org/c/osmo-iuh/+/38946/comment/eebd1808_d0f25791?usp… : PS13, Line 879: exact I think this is possible for hnbs and not forbidden. https://gerrit.osmocom.org/c/osmo-iuh/+/38946/comment/c6dd3724_1eda2718?usp… : PS13, Line 883: if (!osmo_lai_cmp(&entry->rai.lac, lai)) { What do you mean? I think it is ok, to break here. We tx a paging request to a single RNC about this LAC. So breaking this inner llist_for_each is correct. https://gerrit.osmocom.org/c/osmo-iuh/+/38946/comment/c6232366_a5f9bdbd?usp… : PS13, Line 893: } No, we need to tx a page request to a RNC at most once. But we don't want to exit, after paging a single RNC. https://gerrit.osmocom.org/c/osmo-iuh/+/38946/comment/624dc0c8_117fb834?usp… : PS13, Line 914: int ranap_iu_page_ps2(const char *imsi, const uint32_t *ptmsi, const struct osmo_routing_area_id *rai) In the header. I don't see a reason, why to put it into the .c file. If it's in the header, IDEs can parse it and use it. -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/38946?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I1f07e96642737160d387de3e4c3f71d288d356dd Gerrit-Change-Number: 38946 Gerrit-PatchSet: 13 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 20 Feb 2025 15:00:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>