pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/38809?usp=email ) Change subject: ipaccess: Reduce scope of line local variable ...................................................................... ipaccess: Reduce scope of line local variable Change-Id: I9789cbce74f71505e9b7be1445a0a97007ee37da --- M src/input/ipaccess.c 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve osmith: Looks good to me, approved diff --git a/src/input/ipaccess.c b/src/input/ipaccess.c index 51e6087..92a42f9 100644 --- a/src/input/ipaccess.c +++ b/src/input/ipaccess.c @@ -866,8 +866,6 @@ struct ipaccess_head *hh = (struct ipaccess_head *) msg->data; struct msgb *rmsg; int ret = 0; - /* line might not exist if != bsc||bts */ - struct e1inp_line *line = link->line; /* special handling for IPA CCM. */ if (hh->proto == IPAC_PROTO_IPACCESS) { @@ -875,6 +873,8 @@ int len = msgb_l2len(msg); OSMO_ASSERT(len > 0); uint8_t msg_type = *data; + /* line might not exist if != bsc||bts */ + struct e1inp_line *line = link->line; /* peek the pong for our keepalive fsm */ if (line && msg_type == IPAC_MSGT_PONG) { -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/38809?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I9789cbce74f71505e9b7be1445a0a97007ee37da Gerrit-Change-Number: 38809 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>