Attention is currently required from: keith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/29559 ) Change subject: Update MNCC field validation mask. ...................................................................... Patch Set 1: (2 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-msc/+/29559/comment/e562f6ac_0c86370d PS1, Line 13: #OS5282 OS#5282 File src/libmsc/mncc.c: https://gerrit.osmocom.org/c/osmo-msc/+/29559/comment/281e3ca4_ab5eb5b4 PS1, Line 113: 0x7fff Good catch. It's indeed so easy to forget updating this mask because all other MNCC_F_* entries are defined in 'include/osmocom/msc/mncc.h', while this one lives here. I believe it's a good idea to move MNCC_F_ALL to the header. Will submit a patch on top of yours. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/29559 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I9e7d224e7f2d6d2824b2466752b6e8c994ac5a3d Gerrit-Change-Number: 29559 Gerrit-PatchSet: 1 Gerrit-Owner: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: keith <keith(a)rhizomatica.org> Gerrit-Comment-Date: Mon, 03 Oct 2022 08:38:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment