[L] Change in osmo-bts[master]: refactor: replace rtppayload_is_valid() with preening before enqueue - gerrit-log

25 May 2023

Attention is currently required from: pespin.

falconia has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/32988 )

Change subject: refactor: replace rtppayload_is_valid() with preening before enqueue
......................................................................

Patch Set 3:

(2 comments)

File src/common/l1sap.c:

https://gerrit.osmocom.org/c/osmo-bts/+/32988/comment/6fb30cbf_dd458549 
PS2, Line 1891: 	case PL_DECISION_ACCEPT_ASIS:
...
  I'd go for PL_DECISION_ACCEPT. Sounds shorter and
more familiar to other systems (eg. iptables). Done

File src/common/rtp_input_preen.c:

https://gerrit.osmocom.org/c/osmo-bts/+/32988/comment/e0e1fda7_1bc49a8e 
PS2, Line 37: static bool rtppayload_is_octet_aligned(const uint8_t *rtp_pl, unsigned
payload_len)
...
  Adding it to my mental notes for the next version.
Done

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32988
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I7fc99aeecba8303b56d397b8952de5eea82b301e
Gerrit-Change-Number: 32988
Gerrit-PatchSet: 3
Gerrit-Owner: falconia &lt;falcon(a)freecalypso.org&gt;
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-Attention: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-Comment-Date: Thu, 25 May 2023 19:15:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: falconia &lt;falcon(a)freecalypso.org&gt;
Comment-In-Reply-To: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-MessageType: comment