Attention is currently required from: laforge, keith. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/32374 ) Change subject: e1d: reconnect to osmo-e1d after connection loss ...................................................................... Patch Set 3: (1 comment) Patchset: PS2: Its a problem with the e1d driver in libosmo-e1d. The file descriptors used to exchange the data on the E1 timeslots are under the control of libosmo-abis (in the line data struct). Also this part of the implementation has to interface between the way libosmo-abis manages the E1 line and osmo-e1d. This is already very application specific. It is true, each application using the osmo-e1d client has the same problem but the problem is no different from handling any other socket connection. One could still think to re-design the API towards osmo-e1d to hide everything socket specific from the API user. Basically the driver would be outsourced to libosmo-e1d and replaced with a minimalistic version that just calls API functions and handles some context. Basically we would have some kind of middle layer between libosmo-abis and the original libosmo-e1d API. I am not sure, this might be overcomplicated. (at least the generation of the EV_CONN_LOST might become easier since we could tie that to the control socket) -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/32374 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Iaf4d42c2f009b1d7666e319fabdeb2598aa0b338 Gerrit-Change-Number: 32374 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: keith <keith(a)rhizomatica.org> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: keith <keith(a)rhizomatica.org> Gerrit-Comment-Date: Thu, 20 Apr 2023 15:07:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: keith <keith(a)rhizomatica.org> Gerrit-MessageType: comment