Attention is currently required from: pespin.
falconia has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/32961 )
Change subject: gsm0503_tch_hr_encode(): accept both TS101318 and RFC5993 payloads
......................................................................
Patch Set 1:
(2 comments)
File src/coding/gsm0503_coding.c:
https://gerrit.osmocom.org/c/libosmocore/+/32961/comment/ef3b095d_3df90f13
PS1, Line 1591: for (i = 0; i < 112; i++)
iiuc here we are removing 1 byte with this change.
Yes, I am changing the internal static function to take unprefixed 14-byte payloads
as input, rather than prefixed 15-byte kind with the prefix byte content ignored.
https://gerrit.osmocom.org/c/libosmocore/+/32961/comment/9a370f79_71206d60
PS1, Line 2068: case GSM_HR_BYTES: /* TCH HR in "pure" form */
case GSM_HR_BYTES_RTP_RFC5993: /* TCH HR with RFC 5993
prefix */ […]
Good idea, I'll change the code like you suggest.
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/32961
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I13eaad366f9f68615b9e9e4a5f87396a0e9dea0f
Gerrit-Change-Number: 32961
Gerrit-PatchSet: 1
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 23 May 2023 15:55:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment