Attention is currently required from: Hoernchen, pespin, fixeria. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30415 ) Change subject: vita demod by piotr krysik, modified ...................................................................... Patch Set 5: (18 comments) File Transceiver52M/grgsm_vitac/grgsm_vitac.cpp: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1543): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1d9bf3fa_fd6a1fb7 PS5, Line 20: * the Free Software Foundation, Inc., 51 Franklin Street, Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. This Osmocom project should already include a copy of the (A)GPL. File Transceiver52M/grgsm_vitac/viterbi_detector.cc: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1543): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4908798c_6fbe556b PS5, Line 19: * the Free Software Foundation, Inc., 51 Franklin Street, Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. This Osmocom project should already include a copy of the (A)GPL. Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1543): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8ca33e88_058477ed PS5, Line 31: * const gr_complex * input, trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1543): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c590936d_78302c97 PS5, Line 32: * unsigned int samples_num, trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1543): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5beea15b_a4cae0e4 PS5, Line 33: * gr_complex * rhh, trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1543): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0a2bb1cc_4de8864e PS5, Line 34: * unsigned int start_state, trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1543): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2fa705d7_4186fdcc PS5, Line 35: * const unsigned int * stop_states, trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1543): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ed5c4b29_c21ed35e PS5, Line 36: * unsigned int stops_num, trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1543): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/768c22c0_d186fa07 PS5, Line 41: * rhh: The autocorrelation of the estimated channel trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1543): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7c94754c_aa29f9ec PS5, Line 43: * start_state: Number of the start point. In GSM each burst trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1543): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0ef01eb9_2dca2fda PS5, Line 44: * starts with sequence of three bits (0,0,0) which trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1543): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c694cd00_1f33911b PS5, Line 48: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1543): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0a08ae45_19161809 PS5, Line 50: * OUTPUT: output: Differentially decoded hard output of the algorithm: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1543): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7b23d286_43d1a5d6 PS5, Line 107: * Each part is composed of independent (parallelisable) statements like trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1543): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9176a07b_45138848 PS5, Line 114: * This is very good point for optimisations (SIMD or OpenMP) as it's most time trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1543): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6c9893e4_6ba1862c PS5, Line 115: * consuming part of this function. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1543): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d3220411_bed0f56c PS5, Line 354: * traceback stage. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1543): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b102b1b4_3a195f63 PS5, Line 357: * to a received bit. trailing whitespace -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30415 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I5466c522cf4de984a4810ec46df43a10b52ed78f Gerrit-Change-Number: 30415 Gerrit-PatchSet: 5 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 02 Dec 2022 13:25:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment