Attention is currently required from: laforge, keith.

dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/32374 )

Change subject: e1d: reconnect to osmo-e1d after connection loss ......................................................................

Patch Set 3:

(1 comment)

Patchset:

PS2:

I don't have the full picture nor the time right now (on holidays) to investigate fully. […]

I think for the Keith's specific application it would be better to use the DAHDI driver. I wasn't aware of that this would be the preferred solution for applications that use libosmo-abis.

In its current state the API requires the API user to keep track of the file descriptors and close them if necessary. I would say its probably the better option to merge this patch as it is. It is definitely an improvement and we can split it off later if we really need to.

As far as I can see osmo-e1d-pipe is currently the only other application that uses osmo-e1d directly through its proto_clnt.h API. e1d-ts-pipe.c:ts_fd_cb() would exit if there is a problem accessing a file descriptor of the TS, so this would at least not hang with 100% CPU usage. I wonder if there is other software like this. The manual suggests that an application should go via libosmo-abis.