Attention is currently required from: jolly, fixeria, dexter. Hello Jenkins Builder, jolly, laforge, pespin, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/32693 to look at the new patch set (#2). Change subject: pcu_sock: fix PCUIF interface (PCH) ...................................................................... pcu_sock: fix PCUIF interface (PCH) The PCUIF interface implementation in osmo-bsc provides two ways to access the paging channel (PCH). 1) Under the SAPI PCU_IF_SAPI_PCH PAGING COMMAND messages are accepted as whole macblocks but the format is in the style that we are going to deprecate with PCUIF v.11. Also at the moment those PAGING COMMANDs are not confirmed towards the PCU. This is also not necessary since osmo-pcu would silently drop such confirmations. (see pcu_rx_data_cnf in pcu_l1_if.cpp) 2) Under the SAPI PCU_IF_SAPI_PCH_DT messages are also accepded as macblocks but the SAPI will only accept IMMEDIATE ASSIGNMENT messages. The messages are encapsulated in a struct that holds IMSI (paging group) and TLLI (used for confirmation) as separate struct members. The messages are also confirmed towards the PCU as it should be. Since we want to depreacete the older V.10 version of PCUIF and there is not much benefit in maintaining two interfaces we should use SAPI PCU_IF_SAPI_PCH_DT for both message types. This also requires small adjustments to osmo-pcu (see Depends). Depends: osmo-pcu.git I99cfe373fa157cfb32b74c113ad9935347653a71 Related: OS##5927 Change-Id: I82443f2b402aa2416469c8c50b1c050323ef3b8f --- M include/osmocom/bsc/pcu_if.h M src/osmo-bsc/abis_rsl.c M src/osmo-bsc/pcu_sock.c 3 files changed, 55 insertions(+), 49 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/93/32693/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32693 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I82443f2b402aa2416469c8c50b1c050323ef3b8f Gerrit-Change-Number: 32693 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newpatchset