Attention is currently required from: laforge.
Jenkins Builder has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/31967 )
Change subject: contrib: Add BER testing tool
......................................................................
Patch Set 3:
(27 comments)
File contrib/ber/rtp_ber.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5225):
https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/052f1c98_20950dcb
PS3, Line 97: static const char *amr_rate_by_ft[] = {
static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5225):
https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/b8d29024_305c57fc
PS3, Line 237: for (i=0; i<8*payload_len; i++)
that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5225):
https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/c234b191_94aec00b
PS3, Line 237: for (i=0; i<8*payload_len; i++)
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5225):
https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/98d67d55_4be24adf
PS3, Line 237: for (i=0; i<8*payload_len; i++)
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5225):
https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/ee0c8f30_dc399226
PS3, Line 246: if (ones < 32) // This frames is probably us underrunning Tx,
don't use it
that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5225):
https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/f8a056c4_48105874
PS3, Line 258: if (as->state == RUNNING)
that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5225):
https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/9913c91c_a904d120
PS3, Line 361: else
else should follow close brace '}'
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5225):
https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/e878e7cb_28e7dcb5
PS3, Line 399: if (as->state == WAIT_CONN)
that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5225):
https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/977eac73_e73b4368
PS3, Line 420: if (rtp_seq_num_diff(seq_number, as->rx_last_seq) > 1) {
braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5225):
https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/e9161c3c_0dd80916
PS3, Line 431: if (d > 1)
that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5225):
https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/cff2fa55_3dbe298d
PS3, Line 485: while (1) {
braces {} are not necessary for single statement blocks
File contrib/ber/rtp_gen_map.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5225):
https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/74e2bfa3_6b947b6b
PS3, Line 30: int i,j;
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5225):
https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/2a96ad6a_56a590af
PS3, Line 34: for (i=0; i<260; i++)
that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5225):
https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/5b311e61_089d940b
PS3, Line 34: for (i=0; i<260; i++)
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5225):
https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/94032383_4687c98e
PS3, Line 34: for (i=0; i<260; i++)
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5225):
https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/9f667001_655df301
PS3, Line 55: for (i=0; i<260; i++)
that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5225):
https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/2f63ff1e_6c284f16
PS3, Line 55: for (i=0; i<260; i++)
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5225):
https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/9c395a18_1cf3adfe
PS3, Line 55: for (i=0; i<260; i++)
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5225):
https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/70e84536_2a6fab37
PS3, Line 96: for (i=0; i<16; i++)
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5225):
https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/5bab1f31_3ddfe8bd
PS3, Line 96: for (i=0; i<16; i++)
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5225):
https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/5483534a_bd3de56c
PS3, Line 99: for (i=0; i<244; i++)
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5225):
https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/4708cb3f_5d56dc79
PS3, Line 99: for (i=0; i<244; i++)
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5225):
https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/08eb6ab4_c6116f02
PS3, Line 102: for (i=0; i<4; i++)
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5225):
https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/feab452c_4e0d67d4
PS3, Line 102: for (i=0; i<4; i++)
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5225):
https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/faa7d6e9_c72aef96
PS3, Line 116: for (i=0; i<len; i++)
that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5225):
https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/d1a7d4db_f96bc008
PS3, Line 116: for (i=0; i<len; i++)
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5225):
https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/c3c634f8_c4df2d8a
PS3, Line 116: for (i=0; i<len; i++)
spaces required around that '<' (ctx:VxV)
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bts/+/31967
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I1cffa0ae959e29ec61775b13185fd1057ed7485a
Gerrit-Change-Number: 31967
Gerrit-PatchSet: 3
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: tnt <tnt(a)246tNt.com>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Fri, 17 Mar 2023 18:01:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment