Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32653 ) Change subject: nanoBTS: print [supported] versions of MOs ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/osmo-bsc/bts_ipaccess_nanobts.c: https://gerrit.osmocom.org/c/osmo-bsc/+/32653/comment/0060ab60_144d2884 PS1, Line 222: if (!is_ipa_abisip_bts(bts)) Not sure if this check makes sense in a file which is all about the IPA A-bis/IP nanoBTS, but it looks like new code should follow it rather than precede? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32653 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I9aefcae31dc9139e90161b4690e77d4958021d45 Gerrit-Change-Number: 32653 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 08 May 2023 16:56:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment