Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/30569 )

Change subject: Refactor code related to DL-TBF upgrade to multislot ......................................................................

Patch Set 3:

(1 comment)

File src/tbf_dl_fsm.c:

https://gerrit.osmocom.org/c/osmo-pcu/+/30569/comment/73808227_e53ce6d1 PS3, Line 347: dl_tbf_upgrade_to_multislot

So we check if this TBF can be upgraded to multislot prior to this, but do we check if we actually h […]

The current code doesn't allow "checking if we actually have enough resources", since the alloc_algo is touching itself the state of the tbf/pdch/ms afaiu. I have ideas to make the resource allocation a 2 step process of finding a result and later on allocating, but that's not yet there. In any case, I'm by no means worsening the state here. In previous state the PDCHs were detached from the TBF but the TBF was not freed.