Attention is currently required from: neels.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/36520?usp=email )
Change subject: fixup for re-est: do not succeed on acceptance fail ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
Commit Message:
https://gerrit.osmocom.org/c/osmo-msc/+/36520/comment/db4f8ffe_cd2242fd PS1, Line 18: Related: SYS#5130 Fixes: ae98b97382285420ba81549bc874b9fea5e7daa9
File src/libmsc/msc_a.c:
https://gerrit.osmocom.org/c/osmo-msc/+/36520/comment/ae0c33e2_bd6ef57a PS1, Line 165: if (conn_accepted) { Can we please try refactoring this function? I see "if (conn_accepted)" spread like in 4 different places now. Without knowing this, code, looks like stuff could be moved around to really simplify the logic here. That would have probably also helped back in time when the bug was introduced.
-
pespin