Attention is currently required from: laforge, pespin, fixeria, dexter.
falconia has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/32714 )
Change subject: FR/HR/EFR TCH DL: implement DTX rules
......................................................................
Patch Set 8:
(2 comments)
This change is ready for review.
Commit Message:
https://gerrit.osmocom.org/c/osmo-bts/+/32714/comment/15f8732c_13b74341
PS2, Line 8:
The new patchset has a reworded commit message -
please review.
The latest version explicitly refers to DTX and all 3 codecs in the
one-line commit summary.
File src/common/l1sap.c:
https://gerrit.osmocom.org/c/osmo-bts/+/32714/comment/822fd6b6_5cd956b8
PS4, Line 1393: * until OS#5688 is resolved. */
It looks like I need to change that comment and
include a longer explanation of why I am not support […]
OS#5688 is now solved on
the BTS side, and the current version of the present patch supports all 3 codecs.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bts/+/32714
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I924ab21952dcf8bb03ba7ccef790474bf66fc9e5
Gerrit-Change-Number: 32714
Gerrit-PatchSet: 8
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 27 May 2023 20:37:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: falconia <falcon(a)freecalypso.org>
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: comment