Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27778 ) Change subject: osmo-bts-trx: amr_loop: do not miss C/I samples ...................................................................... Patch Set 1: (1 comment) File src/osmo-bts-trx/amr_loop.c: https://gerrit.osmocom.org/c/osmo-bts/+/27778/comment/24625fee_4198ded5 PS1, Line 53: if (mi != chan_state->dl_cmr) Doesn't this mean that you end up with an average lqual_cb which was received while the MS was using another codec than the one announced? So that means the lqual relates to an unknown codec, so the decisions taken may be biased. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27778 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ieb5473ead7200f652b5d0e339e4e252d6567482d Gerrit-Change-Number: 27778 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 14 Apr 2022 12:50:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment