Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30413 ) Change subject: bladerf xa4 support ...................................................................... Patch Set 1: (57 comments) File Transceiver52M/device/bladerf/bladerf.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/bca2278b_a36b586f PS1, Line 56: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/24d40c12_9293db06 PS1, Line 58: const std::vector<std::string> &tx_paths, const std::vector<std::string> &rx_paths); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/bfceb675_607f2e6e PS1, Line 58: const std::vector<std::string> &tx_paths, const std::vector<std::string> &rx_paths); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/ab43e3fd_62ef6efe PS1, Line 58: const std::vector<std::string> &tx_paths, const std::vector<std::string> &rx_paths); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/83db1139_040c1275 PS1, Line 58: const std::vector<std::string> &tx_paths, const std::vector<std::string> &rx_paths); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/0850ff55_ac646b5a PS1, Line 61: int open(const std::string &args, int ref, bool swap_channels); need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/6a0e8967_7008fa3f PS1, Line 62: bool start(); Bad function definition - bool start() should probably be bool start(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/5feb8566_d801bd6c PS1, Line 63: bool stop(); Bad function definition - bool stop() should probably be bool stop(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/26820d48_de022792 PS1, Line 64: bool restart(); Bad function definition - bool restart() should probably be bool restart(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/ca3a2797_3a18b370 PS1, Line 65: enum TxWindowType getWindowType() Bad function definition - enum TxWindowType getWindowType() should probably be enum TxWindowType getWindowType(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/91a6d585_d69e0639 PS1, Line 65: enum TxWindowType getWindowType() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/fb491306_992d04bf PS1, Line 70: int readSamples(std::vector<short *> &bufs, int len, bool *overrun, TIMESTAMP timestamp, bool *underrun); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/bfed8f8d_aedb231d PS1, Line 70: int readSamples(std::vector<short *> &bufs, int len, bool *overrun, TIMESTAMP timestamp, bool *underrun); need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/c854d89e_fa959d4f PS1, Line 70: int readSamples(std::vector<short *> &bufs, int len, bool *overrun, TIMESTAMP timestamp, bool *underrun); spaces required around that '>' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/d3b66a52_6ee30203 PS1, Line 72: int writeSamples(std::vector<short *> &bufs, int len, bool *underrun, TIMESTAMP timestamp); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/46b8a722_a5100a97 PS1, Line 72: int writeSamples(std::vector<short *> &bufs, int len, bool *underrun, TIMESTAMP timestamp); need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/7aeeb97b_29f6809e PS1, Line 72: int writeSamples(std::vector<short *> &bufs, int len, bool *underrun, TIMESTAMP timestamp); spaces required around that '>' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/3b5ffdb2_5ecf8684 PS1, Line 72: int writeSamples(std::vector<short *> &bufs, int len, bool *underrun, TIMESTAMP timestamp); function definition argument 'short *' should also have an identifier name Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/59b0a455_0cf2b4e0 PS1, Line 79: TIMESTAMP initialWriteTimestamp(); Bad function definition - TIMESTAMP initialWriteTimestamp() should probably be TIMESTAMP initialWriteTimestamp(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/5d806beb_f7fec483 PS1, Line 80: TIMESTAMP initialReadTimestamp(); Bad function definition - TIMESTAMP initialReadTimestamp() should probably be TIMESTAMP initialReadTimestamp(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/03eab3ca_15ffc725 PS1, Line 82: double fullScaleInputValue(); Bad function definition - double fullScaleInputValue() should probably be double fullScaleInputValue(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/bc1b1539_9230b2a9 PS1, Line 83: double fullScaleOutputValue(); Bad function definition - double fullScaleOutputValue() should probably be double fullScaleOutputValue(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/23dd8e5b_2c975ba2 PS1, Line 87: double maxRxGain(void) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/416e026b_3aa5766c PS1, Line 91: double minRxGain(void) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/0af1117f_3fe8ab1d PS1, Line 104: double getRxFreq(); Bad function definition - double getRxFreq() should probably be double getRxFreq(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/84e8dfaf_4792f18b PS1, Line 106: bool setRxAntenna(const std::string &ant, size_t chan) need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/34afb39e_0c0ccac0 PS1, Line 106: bool setRxAntenna(const std::string &ant, size_t chan) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/76a028d7_19cb6b50 PS1, Line 110: std::string getRxAntenna(size_t chan) labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/50c48b94_4eecb2e4 PS1, Line 114: bool setTxAntenna(const std::string &ant, size_t chan) need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/67f2d6d4_daedd21f PS1, Line 114: bool setTxAntenna(const std::string &ant, size_t chan) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/8d3da6cb_241defd3 PS1, Line 118: std::string getTxAntenna(size_t chan) labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/3e1da1d6_67153f2a PS1, Line 123: bool requiresRadioAlign(); Bad function definition - bool requiresRadioAlign() should probably be bool requiresRadioAlign(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/d7f5a78a_e43f0222 PS1, Line 125: GSM::Time minLatency(); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/a1384af4_9b1fe7a5 PS1, Line 127: inline double getSampleRate() Bad function definition - double getSampleRate() should probably be double getSampleRate(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/5f51b6ca_3cc50e9c PS1, Line 135: bool recv_async_msg(); Bad function definition - bool recv_async_msg() should probably be bool recv_async_msg(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/36c70268_5df31bc1 PS1, Line 144: protected: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/d44686cf_bcbdf7df PS1, Line 155: std::vector<double> tx_gains, rx_gains; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/24e11f17_453353e7 PS1, Line 155: std::vector<double> tx_gains, rx_gains; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/e9e8c6e1_81ef3142 PS1, Line 155: std::vector<double> tx_gains, rx_gains; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/50040567_f9317f72 PS1, Line 156: std::vector<double> tx_freqs, rx_freqs; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/1ec98268_c7e3122c PS1, Line 156: std::vector<double> tx_freqs, rx_freqs; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/3799ee8b_e7c9f999 PS1, Line 156: std::vector<double> tx_freqs, rx_freqs; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/49329394_fd0f1b38 PS1, Line 169: std::vector<smpl_buf *> rx_buffers; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/c6943008_44cee1cc PS1, Line 169: std::vector<smpl_buf *> rx_buffers; need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/0083b7c9_ea8af053 PS1, Line 169: std::vector<smpl_buf *> rx_buffers; spaces required around that '>' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/768422f1_6b1dc3aa PS1, Line 169: std::vector<smpl_buf *> rx_buffers; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/010b711e_bc7d4e65 PS1, Line 171: std::vector<std::vector<short> > pkt_bufs; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/95926dc9_78d8e7c0 PS1, Line 171: std::vector<std::vector<short> > pkt_bufs; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/32fe518d_9ea59c7e PS1, Line 171: std::vector<std::vector<short> > pkt_bufs; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/eec062fd_0c681c84 PS1, Line 171: std::vector<std::vector<short> > pkt_bufs; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/53dff1f5_45272f96 PS1, Line 174: std::vector<short *> pkt_ptrs; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/1b442535_1dc1ae89 PS1, Line 174: std::vector<short *> pkt_ptrs; need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/0b49c0f6_c9feffd2 PS1, Line 174: std::vector<short *> pkt_ptrs; spaces required around that '>' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/e59cfb6a_1dd7943b PS1, Line 174: std::vector<short *> pkt_ptrs; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/1d0122a9_76d03002 PS1, Line 176: void init_gains(); Bad function definition - void init_gains() should probably be void init_gains(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/4e8aa58f_7bf4946c PS1, Line 178: void set_rates(); Bad function definition - void set_rates() should probably be void set_rates(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/97453589_e3e61b48 PS1, Line 182: void get_dev_band_desc(dev_band_desc &desc); need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30413 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I455c34bb9520d5f09eeb1ac76fceb4bdea94d1ac Gerrit-Change-Number: 30413 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen &lt;ewild(a)sysmocom.de&gt; Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Thu, 01 Dec 2022 11:01:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment