Attention is currently required from: daniel, fixeria, laforge, osmith.
arehbein has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-netif/+/33198?usp=email )
Change subject: stream: Add client-side (segmentation) support for IPA
......................................................................
Patch Set 21:
(2 comments)
Patchset:
PS21:
what I don't really understand here is why there
is no code being removed. […]
The plan is to tackle this kind of task once these
preliminary libosmo-netif changes have been submitted.
PS21:
I guess printing the timestamp infront of the log
should just be removed? from a quick glance this s […]
What we have observed was
that sometimes, an arbitrary number of loop iterations is needed until the code section in
question becomes active (each loop iteration contains one timestamp increment), and
sometimes the code needs exactly the minimum number of loop needed.
I'm suspecting it's due to nondeterministic compiler behavior, probably caused by
type punning (Vadim has also already seen a warning because of this). The reason for this
assumption being that behavior never differed for the same binary and only changed between
compilations, even for the same code (but with changed timestamps due to trying different
commits etc. in between).
I will add a patch suggestion to get rid of the type punning, hoping we won't see this
ever again.
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-netif/+/33198?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I822abf52c6ae396c90b5c50228a0a39c848d3de6
Gerrit-Change-Number: 33198
Gerrit-PatchSet: 21
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: daniel <dwillmann(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 13 Sep 2023 18:22:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: arehbein <arehbein(a)sysmocom.de>
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de>
Gerrit-MessageType: comment