Attention is currently required from: falconia. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33063 ) Change subject: coding: gsm0503_tch_{fr,hr}_encode(): add ability to emit BFI ...................................................................... Patch Set 1: Code-Review+1 (2 comments) File src/coding/gsm0503_coding.c: https://gerrit.osmocom.org/c/libosmocore/+/33063/comment/8f26d59c_f41188b4 PS1, Line 1953: 185 `sizeof(conv)` - this way it's clear that you're zero-initializing the whole buffer. https://gerrit.osmocom.org/c/libosmocore/+/33063/comment/4ff50aec_ef8e6c92 PS1, Line 2113: 98 same here, `sizeof(conv)` please -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33063 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iade3310e16b906efb6892d28f474a0d15204e861 Gerrit-Change-Number: 33063 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Sat, 27 May 2023 10:24:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment