Attention is currently required from: Hoernchen.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmocom-bb/+/30054 )
Change subject: trxcon: maintain full power scan state in the trxcon_fsm
......................................................................
Patch Set 1:
(1 comment)
File src/host/trxcon/src/trxcon_fsm.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/30054/comment/97a2a9de_7824b812
PS1, Line 229: %s (expected %s
Hmm, why doesn't gcc complain about wrong format string specifiers?
When using LOGPFSML(), the macro expansion chain is as follows:
LOGPFSML()
-> LOGPFSMLSRC()
-> LOGPFSMSLSRC()
-> LOGPSRC()
-> LOGPSRCC()
-> logp2() __attribute__ ((format (printf, 6, 7)))
The logp2() has the format attribute, which gives GCC a hint on format string checking.
--
To view, visit
https://gerrit.osmocom.org/c/osmocom-bb/+/30054
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Ic5f724a11e225b439ec10aed7697e3e03b7929e5
Gerrit-Change-Number: 30054
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 08 Nov 2022 14:21:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment