Attention is currently required from: pespin.

dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/33768 )

Change subject: bts: send IMMEDIATE ASSIGNMENT via AGCH when no IMSI is available ......................................................................

Patch Set 2:

(5 comments)

Patchset:

PS1:

This cannot be merged until we confirm the ImmAss on AGCH back to PCU. […]

This means we would confirm any AGCH message, regardless if the IMMEDIATE ASSIGNMENT is for DL or UL TBF?

(I would send the confirmation when the AGCH message is pulled from the queue in bts.c:bts_ccch_copy_msg)

File src/bts.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/33768/comment/0fa73c00_7307b10e PS1, Line 1126: if (strlen(tbf->imsi()) < 3) {

ms_imsi_is_valid()

Done

https://gerrit.osmocom.org/c/osmo-pcu/+/33768/comment/03b38989_22e2fe4c PS1, Line 1127: /* In case the IMSI is not yet known, the IMMEDIATE ASSIGNMENT is sent on the AGCH. The reason

Maybe explain that the usual case around here is during GMM attach, where the SGSN still didn't lear […]

Done

File src/pcu_l1_if.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/33768/comment/2c597f33_bb2d75e5 PS1, Line 278: /* OS#6097: if strlen(imsi) == 0: We assume the MS is in non-DRX

imsi_len = strlen(imsi); […]

Done

https://gerrit.osmocom.org/c/osmo-pcu/+/33768/comment/b1d1505a_d6567e41 PS1, Line 310: /* OS#6097: if strlen(pch_dt.imsi) == 0: We assume the MS is in non-DRX

Same as above.

Done