Attention is currently required from: laforge. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/30446 )

Change subject: Fix support for HDLC/RAW type channels at mISDN.c ......................................................................

Patch Set 1:

(1 comment)

File src/input/misdn.c:

https://gerrit.osmocom.org/c/libosmo-abis/+/30446/comment/4d0bbf8e_4df74767 PS1, Line 690: /* TS 16 is the D-channel, so we use D-channel proto */ : bfd->fd = socket(PF_ISDN, SOCK_DGRAM, : (ts == 16) ? ISDN_P_NT_E1 : ISDN_P_B_HDLC);

the problem here is that it makes assumptions. […]

mISDN handles TS 16 different, so that ISDN_P_NT_E1 must be given instead of ISDN_P_B_HDLC. The result is the same, both use HDLC mode. Opening TS 16 as 'b' channel does not work with mISDN.

Only NT mode is supported in all other places of misdn.c. Support of TE mode would require changes to the API or additional e1in_driver.

E1INP_TS_TYPE_SIGN works with kernel space or user space LAPD on top of HDLC. We cannot use that when we want pure HDLC. (E.g frame relay function of V5 interface)